Skip to content

[Payment due @abzokhattab] Show a page count badge on multi-page PDF receipts - #97813

Open
ishpaul777 wants to merge 17 commits into
Expensify:mainfrom
ishpaul777:ishpaul/667914-receipt-page-badge
Open

[Payment due @abzokhattab] Show a page count badge on multi-page PDF receipts#97813
ishpaul777 wants to merge 17 commits into
Expensify:mainfrom
ishpaul777:ishpaul/667914-receipt-page-badge

Conversation

@ishpaul777

@ishpaul777 ishpaul777 commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

A PDF receipt's thumbnail is a server-generated JPG of page 1. When a multi-page receipt's total sits on page 2 or later, the expense looks like it disagrees with its own receipt, and nothing on screen signals that more pages exist. Hover-zoom does not help — it magnifies the same first page.

This adds a Page 1 of N badge over the receipt in the expense detail view, gated on pageCount > 1.

Design settled on the plain shared Badge with no icon, so that is what ships: default Badge styling, positioned bottom-left because the receipt action buttons own the top-right corner on hover.

It renders as a sibling of the hover-zoom wrapper rather than inside it, so magnifying the receipt does not scale the badge with it, and it waits for the receipt to load because the container stretches while loading and would otherwise strand the badge at the bottom of that taller box.

One thing worth a second look from design: the default Badge is a solid light-grey pill in light mode, so over a typical white PDF thumbnail the contrast is modest — and low visibility is the exact problem this PR exists to solve. Happy to switch to a higher-contrast treatment if design prefers.

This depends on three backend PRs and shows nothing until they ship, since pageCount does not exist on any receipt today:

There is no backfill, so the badge only ever appears on receipts uploaded after the backend ships. The pageCount > 1 gate handles that with no extra code.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/667914
PROPOSAL:

Tests

Automated: tests/ui/components/MoneyRequestReceiptViewTest.tsx covers the gating — the badge renders for a multi-page PDF, and stays hidden for a single-page receipt and for one carrying no count at all (which is also what a PDF uploaded before the backend reported counts looks like).

Manual steps below require the three backend PRs running locally.

  1. Submit an expense and attach a PDF receipt with 3 pages where the total appears only on the last page.
  2. Open the expense detail view.
  3. Verify a Page 1 of 3 badge appears at the bottom-left of the receipt.
  4. Verify the badge does not overlap the receipt action buttons when hovering the receipt.
  5. Submit an expense with a single-page PDF receipt and verify no badge appears.
  6. Submit an expense with an image receipt and verify no badge appears.
  7. Open an expense created before the backend change and verify no badge appears and no errors occur.
  8. Switch between light and dark theme and verify the badge stays legible in both.
  9. Verify the badge does not appear anywhere outside the expense detail view.
  • Verify that no errors appear in the JS console

Offline tests

The page count arrives with the transaction from Onyx and is not fetched separately, so a cached expense keeps its badge offline.

  1. Open an expense with a multi-page PDF receipt while online and confirm the badge shows.
  2. Disconnect the network.
  3. Reopen the expense and verify the badge still shows.

QA Steps

Same as tests. Requires the three backend PRs deployed — the badge cannot appear before then, and only on receipts uploaded after they ship.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

\

Android: Native
Android: mWeb Chrome
iOS: Native Screenshot 2026-08-12 at 9 35 02 PM
iOS: mWeb Safari Screenshot 2026-08-12 at 9 37 37 PM
MacOS: Chrome / Safari Screenshot 2026-08-11 at 3 59 28 PM

ishpaul777 and others added 3 commits August 4, 2026 22:03
Auth now sends the page count for receipts stored as a PDF.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The receipt thumbnail is a server-generated JPG of page 1, so when a total sits
on a later page the expense looks like it disagrees with its own receipt, and
nothing signals that more pages exist.

The badge sits bottom-left because the receipt action buttons hold the
top-right corner, and uses the same translucent dark background as the video
player controls so it stays legible over any receipt content in either theme.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@melvin-bot

melvin-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

ishpaul777 and others added 5 commits August 10, 2026 22:36
Design settled on the plain Badge rather than a bespoke translucent pill with an
icon, so this drops the custom styles and the page-stack icon and keeps only the
positioning override.

The badge also moves out of ReceiptHoverZoom's children and becomes a sibling of
the zoom wrapper, alongside the receipt action buttons. Inside, hover-zoom
magnified the badge along with the receipt; outside, it stays put while the
receipt scales under it.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Upstream stopped importing parameter types from params.ts and now types
translation parameters inline, so the page count copy follows that convention
and ReceiptPageCountParams is gone.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The receipt container takes flex1 while loading, so it stretches and an
absolutely positioned badge lands at the bottom of that taller box rather than
on the receipt. The receipt action buttons already wait for the load for the
same reason.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Generated with scripts/generateTranslations.ts, which the CI workflow cannot run
for a PR from a fork.

French came back unchanged from the model and fell back to English, so it is
translated by hand. Spanish already matched what the script produced.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ishpaul777
ishpaul777 marked this pull request as ready for review August 11, 2026 10:39
@ishpaul777
ishpaul777 requested review from a team as code owners August 11, 2026 10:39
@melvin-bot
melvin-bot Bot requested review from abzokhattab and garrettmknight and removed request for a team August 11, 2026 10:39
@melvin-bot

melvin-bot Bot commented Aug 11, 2026

Copy link
Copy Markdown

@abzokhattab Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot removed the request for review from a team August 11, 2026 10:39
DebugUtils mirrors the Receipt type as a runtime field map, and both validators
must enumerate every key, so adding pageCount to the type broke typecheck until
they listed it too.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Comment thread src/styles/index.ts Outdated
@codecov

codecov Bot commented Aug 11, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...nents/ReportActionItem/MoneyRequestReceiptView.tsx 71.54% <100.00%> (+0.34%) ⬆️
src/libs/DebugUtils.ts 69.07% <ø> (ø)
src/libs/actions/IOU/Receipt.ts 77.64% <ø> (ø)
src/libs/actions/MergeTransaction.ts 66.16% <100.00%> (ø)
src/styles/index.ts 63.00% <ø> (ø)
... and 13 files with indirect coverage changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 281aa9b36e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const hasReceipt = hasReceiptTransactionUtils(displayedTransaction);
// The thumbnail only ever renders page 1 of a PDF, so a total sitting on a later page looks like it
// disagrees with the expense amount. Only multi-page receipts need the badge.
const receiptPageCount = displayedTransaction?.receipt?.pageCount ?? 0;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Clear stale page counts when replacing receipts

When a multi-page PDF is replaced, replaceReceipt() in src/libs/actions/IOU/Receipt.ts applies an Onyx MERGE whose nested receiptOptimistic object omits pageCount; therefore the previous count remains in Onyx. Since this line trusts that retained value without checking whether the new receipt is a PDF, replacing the PDF with an image—or with a PDF having fewer pages—shows the old Page 1 of N badge after loading, and an image response that omits this PDF-only field may never clear it. Clear pageCount in receipt replacement paths or gate the badge against the current receipt type.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed and fixed in 5e7544a. receiptOptimistic is applied with Onyx.METHOD.MERGE, so omitting pageCount left the replaced receipt's count in place until the server responded. Now sends pageCount: null, matching how localSource is already cleared in the same object, and the type allows null.

Worth noting the server side of this is already handled — Auth's attach/replace update always sends pageCount (null when the new receipt has none), so the correction arrives rather than the field simply being omitted. This closes the optimistic window before it.

ishpaul777 and others added 2 commits August 11, 2026 16:23
The style stopped setting a background when the badge moved to the shared Badge
component, but the comment describing that background survived a partial edit
and sat above the new one.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
replaceReceipt applies its optimistic receipt as a merge, so omitting pageCount
left the replaced receipt's count in Onyx. Replacing a multi-page PDF with an
image showed the old badge until the server responded. Sending null clears it,
matching how localSource is already cleared in the same object.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@abzokhattab

Copy link
Copy Markdown
Contributor

@codex @MelvinBot review the pr

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Code review — the change is small, well-commented, and the logic (Onyx-driven pageCount, > 1 gate, optimistic clear on replace, number | null type) is sound. A few things to reconcile before merge:

1. Implementation doesn't match the PR description (please reconcile)

The description promises a "translucent dark pill … reuses theme.videoPlayerBG … paired with theme.white" plus a "page-stack icon". The shipped code does none of that — it renders a plain default Badge:

This also undercuts the description's own contrast rationale. The default badge is a solid light-gray pill in light mode, so over a typical white PDF thumbnail it's low-contrast and easy to miss — which is the exact "users don't notice multi-page receipts" problem this PR set out to fix. Either update the description to reflect the simpler default badge, or implement the dark-pill + icon you described. Since design hasn't weighed in yet, worth deciding this now rather than after.

2. "Added unit tests" is checked, but there are no tests in the diff

The author checklist marks "I added unit tests … to prevent regressions", but no test file is included. The gating logic (pageCount > 1 && !isLoading, image vs PDF, null on replace) is exactly the kind of thing a small unit test would lock in. Either add one or uncheck the box.

Minor
  • DebugUtils validates pageCount as 'number' (DebugUtils.ts:831 and :1200), but the type is number | null. Editing it to null via the debug tool would fail validation. Debug-only, low impact.
  • en.ts placement is inconsistent with the other locales (it sits before addAReceipt, the rest place it after) — harmless, just noting.

I did not exercise this in a live web session: pageCount doesn't exist on any receipt until the three backend PRs ship, so there's nothing for the badge to render against yet — the only thing verifiable in-app today is the negative case (no badge, no errors), which the code trivially satisfies.

Otherwise the reasoning comments are genuinely good — the !isLoading gate, the optimistic pageCount: null on replace, and the marginLeft: 0 override are all correctly explained.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

Reviewed commit: 5e7544a042

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Asserts the badge renders for a multi-page PDF and stays hidden for a single
page receipt and for one with no count at all, which is also what a PDF uploaded
before the backend reported counts looks like.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ishpaul777

ishpaul777 commented Aug 11, 2026

Copy link
Copy Markdown
Contributor Author

Both main points were right — fixed.

1. Description vs implementation. The description was stale: it still described the translucent-dark-pill-plus-icon I originally built, before design asked for the plain shared Badge. Rewritten to describe what actually ships, and I carried your contrast concern into it as an open question for design rather than burying it — a light-grey pill over a white PDF thumbnail is weak, and low visibility is the problem this PR exists to solve.

2. Unit tests. Added in ccb27a3, in the existing tests/ui/components/MoneyRequestReceiptViewTest.tsx: badge renders for a multi-page PDF, stays hidden for a single-page receipt and for one with no count at all. Verified they bite — weakening the gate to > 0 fails the single-page case.

On the minor points:

  • DebugUtils 'number' vs number | null — real, but localSource is string | null and validated as 'string' in the same two maps, so pageCount matches the established pattern. Changing only mine would diverge; happy to fix both if you'd rather.
  • en.ts ordering — left alone. en.ts and es.ts are hand-written and group it next to crop; the other nine are generated and the script appends at the end. Key order has no behavioral effect, so I'd rather not churn nine files over a generator artifact.

garrettmknight
garrettmknight previously approved these changes Aug 11, 2026

@garrettmknight garrettmknight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from a product perspective

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Screenshot looks good but would love to see a mobile screenie too

@ishpaul777

Copy link
Copy Markdown
Contributor Author

Screenshot looks good but would love to see a mobile screenie too

IOS screenshot attached

Screenshot 2026-08-12 at 9 35 02 PM

@dannymcclain

Copy link
Copy Markdown
Contributor

Nice. Looking good to me.

@abzokhattab

Copy link
Copy Markdown
Contributor

Thanks!! reviewing it

@abzokhattab

abzokhattab commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Manual steps below require the three backend PRs running locally.

how can i run the tests looks like it requires running a backend locally is that correct @ishpaul777

i think we can inject the onyx states using the console let me know if that would sufficient

@quinthar quinthar removed the #migrate label Aug 13, 2026
@ishpaul777

Copy link
Copy Markdown
Contributor Author

@abzokhattab yes injecting the onyx states using the console will be sufficient, BE PRs not merged yet, this PR change is backward compatible so its safe to merge first

@abzokhattab

Copy link
Copy Markdown
Contributor

The pageCount: null fix in replaceReceipt covers the replace path, but the same stale-count problem still exists in the merge flow.

Cause: mergeTransactionRequest writes the chosen receipt with Onyx.METHOD.MERGE:

value: {receipt: mergeTransaction.receipt ?? null}   // MergeTransaction.ts:347-353

mergeTransaction.receipt is the full receipt object of whichever expense the user picked. Since Onyx deep-merges, keys missing from the new receipt survive from the old one — so picking an image receipt leaves the previous PDF's pageCount in place. The badge only checks pageCount > 1 && !isLoading, with no receipt-type check, so it renders Page 1 of N on a single-page photo.

Repro

  1. Open an expense with a PDF receipt.
  2. const t = await window.transaction; const key = \transactions_${t.transactionID}`;`
  3. await window.Onyx.merge(key, {receipt: {pageCount: 3}}); → badge shows Page 1 of 3.
  4. Apply what the merge flow writes when you keep the other expense's image receipt:
    await window.Onyx.merge(key, {receipt: {receiptID: 999, source: '<jpg url>', filename: 'photo.jpg'}});
  5. Receipt is now a JPG, but pageCount: 3 survives and the badge still reads Page 1 of 3.
Screen.Recording.2026-08-13.at.11.29.56.mov

Suggested fix — gate on the receipt actually being a PDF, which closes this path and any future optimistic writer in one line:

const shouldShowReceiptPageCount = receiptPageCount > 1 && Str.isPDF(receiptURIs?.filename ?? '') && !isLoading;

The merge flow writes the chosen receipt with a merge, so picking an image left
the target's old PDF page count in Onyx and the badge rendered "Page 1 of N"
over a photo. Gating on the current file type fixes that and any future
optimistic writer, since a page count only means anything for a PDF.

The merge flow also clears the count explicitly now, so the stale value does not
sit in Onyx for other consumers, matching what replaceReceipt already does.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@abzokhattab

abzokhattab commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Oops, we have a lot of failing pipelines @ishpaul777

cc @MelvinBot

ishpaul777 and others added 3 commits August 13, 2026 21:52
SignInModal dismisses itself once IS_LOADING_APP settles to false. The back-handling
test never sets that flag, but Onyx carries it in from whatever ran earlier in the
worker, so the dismiss effect fired in CI and threw on the unmocked dismissModal
before any assertion ran.
@ishpaul777

Copy link
Copy Markdown
Contributor Author

thanks for review @abzokhattab fixed #97813 (comment) and Ci should pass now 🤞

@abzokhattab

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari Screenshot 2026-08-13 at 11 20 42

@abzokhattab abzokhattab left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM .. i was only able to test it on web since the backend is not yet deployed

@melvin-bot melvin-bot Bot changed the title Show a page count badge on multi-page PDF receipts [Payment due @abzokhattab] Show a page count badge on multi-page PDF receipts Aug 14, 2026
@melvin-bot

melvin-bot Bot commented Aug 14, 2026

Copy link
Copy Markdown

🎯 @abzokhattab, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/667914.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants