[Payment due @ikevin127] Render the currency conversion fee payer changelog entry

[ishpaul777]

Explanation of Change

Auth now writes a changelog entry into the #admins room when a workspace admin changes who pays the currency conversion fees on cross-border reimbursements (Auth PR). The action is POLICYCHANGELOG_UPDATE_GLOBAL_REIMBURSEMENTS_FX_PREFERENCE, carrying {"preference": "company"} or {"preference": "employee"}.

This renders it in NewDot:

updated the currency conversion fee setting to "Company pays"

Beyond the room message, the same text is wired into the LHN preview, the search options list, the thread name when the message is grouped into a thread, and copy-to-clipboard, matching how UPDATE_REQUIRE_COMPANY_CARDS_ENABLED is handled. Without those, the LHN would fall back to the English text Auth stores rather than the reader's locale.

The Auth PR should merge first, since nothing produces this action until it deploys. OldDot renders the same wording in https://github.com/Expensify/Web-Expensify/pull/55150.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/655935
PROPOSAL: N/A

Tests

Requires the globalReimbursement and globalReimbursementFX beta .

1. As an admin of a Collect or Control workspace with global reimbursement enabled, go to Workspace > Workflows > Make or track payments and set the currency conversion fees to be paid by the company.
2. Open the workspace's #admins room.
3. Verify a system message reads updated the currency conversion fee setting to "Company pays".
4. Verify the LHN row for #admins shows the same text as its preview.
5. Change the setting back to the employee and verify a second message reads "Employee pays".
6. Save the same setting twice and verify no duplicate message appears.
7. Right click the message, choose Copy to clipboard, and verify the pasted text matches the message.

• Verify that no errors appear in the JS console

Offline tests

The message comes from a report action pushed by the backend, so there is no optimistic path. Offline, the room shows whatever actions were already synced and the setting cannot be changed.

QA Steps

Same as tests.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/CONST/index.ts	94.85% <ø> (ø)
src/libs/OptionsListUtils/index.ts	87.33% <100.00%> (+0.01%)	⬆️
src/libs/ReportActionsUtils.ts	80.00% <100.00%> (+0.04%)	⬆️
src/libs/ReportNameUtils.ts	81.95% <100.00%> (+0.08%)	⬆️
src/libs/SidebarUtils.ts	80.38% <100.00%> (+0.05%)	⬆️
...x/report/actionContents/PolicyChangeLogContent.tsx	100.00% <100.00%> (ø)
...es/inbox/report/ContextMenu/ContextMenuActions.tsx	40.63% <50.00%> (+0.02%)	⬆️
... and 7 files with indirect coverage changes

[ishpaul777]

@MelvinBot review

[ishpaul777]

@codex review

[MelvinBot]

Review

Looks good — clean, minimal, and it faithfully mirrors the existing UPDATE_REQUIRE_COMPANY_CARDS_ENABLED pattern. I verified every render surface that the sibling action touches is covered here, so there are no gaps in where the new message will show up. A couple of non-blocking notes below.

Completeness ✅ — the new action is wired into all five render surfaces plus the CONST entry, the shared type, and unit tests:

• src/libs/SidebarUtils.ts:1167 (LHN alternate text)
• src/libs/OptionsListUtils/index.ts:956 (search options / last message)
• src/libs/ReportNameUtils.ts:855 (thread name)
• src/pages/inbox/report/ContextMenu/ContextMenuActions.tsx:1090 (copy to clipboard)
• src/pages/inbox/report/actionContents/PolicyChangeLogContent.tsx:163 (room message)

A repo-wide grep for the reference action returned exactly these five call sites, and all five are handled.

Notes (non-blocking)

1. Locale typography — nl and it use straight ASCII quotes. The new strings in nl.ts ("Bedrijf betaalt") and it.ts ("Azienda paga") wrap the quoted term in straight "…", whereas those locales use typographic quotes elsewhere (e.g. nl uses “…” on other lines). de, fr, el, ja, pl, zh-hans all look locale-correct, and en/es intentionally use straight quotes to match their surrounding workspaceActions block. Worth aligning nl/it if you're keeping the manual translations.

2. Manual translations vs. the generator. Heads up that you've hand-written all 11 locales. Since this is a fork PR, translations aren't auto-generated, so if an Expensify employee runs the Generate static translations workflow it may regenerate the non-en locales from en.ts and overwrite these. Just make sure the final state is what you intend (either keep the manual ones, or let the workflow own them).

3. Missing-payload fallback. getCurrencyConversionFeeMessage defaults a missing preference to 'employee', so an empty payload still renders a definitive "Employee pays" message rather than nothing. Your unit test documents this as intentional (employee pays unless the company opts in) — flagging only so it's a conscious choice, since it means a malformed/partial action would silently render as "Employee pays" rather than surfacing as unknown.

Testing note

I did not run this through the live web app: the message is produced only by the backend action from the Auth PR, which isn't deployed, so the flow (set FX preference → changelog entry) can't be exercised against the test API yet. The behavior here is fully covered by the unit tests in ReportActionsUtilsTest.ts, which is the right level for this change.

[chatgpt-codex-connector]

Codex Review: Didn't find any major issues. Breezy!

Reviewed commit: a7b03f61a1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[sakluger]

Hey @ishpaul777, how's this one coming?

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[ishpaul777]

this is ready for review now!

[joekaufmanexpensify]

Core design doc issue

[ikevin127]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2026-08-17.at.15.44.01.mov

[ishpaul777]

@ikevin127 all inline comments are addressed and pushed, and I added the SidebarUtils / OptionsListUtils / ReportNameUtils wiring tests you flagged. Also merged main to clear the conflict, so this is ready for another look 🙌

[ikevin127]

@ishpaul777 Thanks for addressing the comments. I attempted to manually test this PR but was not able to get the actions in #admins: the system message doesn't show up - not sure if the Auth PR was deployed yet (I tried both staging server and dev) so let me know about that as I don't know the status of the Auth PR.

Screen.Recording.2026-08-12.at.18.03.06.mov

The latest code is sound. Two small things, neither blocking:

🟢 src/languages/es.ts:8673 and src/languages/pt-BR.ts:8776 - quote style still doesn't match the neighbours in those two files. es uses straight "${preferenceLabel}" while the adjacent workspaceActions entries quote values with «...», and pt-BR went the other way, using curly “${preferenceLabel}” while its neighbour uses straight "${categoryName}". Everything else lines up (de „“, fr «», el «», pl „”, ja 「」, zh “”, it/nl/en straight). Purely cosmetic, but it's a one-character change per file if you want the set fully consistent.

🟢 tests/unit/OptionsListUtilsTest.tsx:5872 - expect(lastMessage).toBe(getCurrencyConversionFeeMessage(translateLocal, action)) asserts the SUT against the same helper it calls internally, so it proves the wiring routes to the right function but would still pass if the helper produced the wrong string. Worth noting this matches the dominant convention in that describe block (the UPDATE_REQUIRE_COMPANY_CARDS_ENABLED, UPDATE_AUTO_HARVESTING and card-feed cases all do the same), so I'm fine leaving it. If you want it to match the strength of the other two tests you added, assert the literal:

expect(lastMessage).toBe('updated the currency conversion fee setting to "Company pays"');

Also worth adding the employee case here for symmetry with SidebarUtilsTest / ReportNameUtilsTest, which both cover both values.

[ishpaul777]

Auth PR was deployed but another dependency https://github.com/Expensify/Web-Expensify/pull/55150 was merged last week but looks like its not deployed yet i'll update once its deployed, for now please verify only by mocking the data in Onyx

[ishpaul777]

https://github.com/Expensify/Web-Expensify/pull/55150 was deployed to staging

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

[ikevin127]

🟢 LGTM - Tests well

[melvin-bot]

🎯 @ikevin127, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/655935.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

[ishpaul777]

@madmax330 can you please final review and merge?

[github-actions]

🚧 madmax330 has triggered a test Expensify/App build. You can view the workflow run here.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[github-actions]

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #97897.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-d5f49ad-3d1e22c-202eb6d8bd20745903aceb735704963827ece822/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-d5f49ad-3d1e22c-55559c66e5c67c06a152304928028a52a7a21008/index.html

Web 🕸️
https://97897.pr-testing.expensify.com

---

👀 View the workflow run that generated this build 👀

[OSBotify]

🚀 Deployed to staging by https://github.com/madmax330 in version: 9.4.57-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[MelvinBot]

Yes — a help site update is needed. This PR surfaces a new global-reimbursement setting where a Workspace Admin chooses whether the company or the employee pays the currency conversion fees on cross-border reimbursements. The existing article Enable-Global-Reimbursement.md currently states the employee always absorbs these fees, which is no longer accurate.

Draft help site PR: #99022

What it changes:

• Adds a task-based section documenting the Workflows > Make or track payments > Currency conversion fees setting (Company pays / Employee pays).
• Updates the FAQ "Why is my employee not receiving the full deposit?" to say the employee absorbs fees by default and admins can change who pays.

Labels/setting text (Currency conversion fees, Company pays, Employee pays) were verified against the App source strings (src/languages/en.ts, src/pages/workspace/workflows/). The setting is beta-gated (globalReimbursement + globalReimbursementFX), so live UI verification wasn't possible on a standard account.

@ishpaul777, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

---

view run

[OSBotify]

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

• Android

[melvin-bot]

🤖 Payment issue created: #99122