feat: add auto-update government distance rates toggle - #97936
Conversation
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: efc8505151
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
This comment has been minimized.
This comment has been minimized.
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
@neil-marcellini made the FE changes but I think we also need disable it when the workspace plan is downgraded? Also I need the copies and icon to use on upgrade page, currently it is: title: 'Auto-update government rates',
description: 'If you want Expensify to keep your mileage rates current whenever your government publishes new guidance, this feature is for you.',
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>Auto-updating government rates is only available on the Control plan, starting at <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `per member per month.` : `per active member per month.`}</muted-text>`,Monosnap.screencast.2026-08-21.01-02-44.mp4 |
|
@Krishna2323 that's looking good to me, nice work! We can see what the design team says. Regarding disabling it on downgrade, we merged a PR to fix that yesterday, so it should deploy today. |
neil-marcellini
left a comment
There was a problem hiding this comment.
Let's fix the failing checks and add translations for the current copy. We can always tweak it later if needed.
|
@neil-marcellini could you please run the translations script? |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index 3fab4aad..2dbe7754 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -7181,7 +7181,7 @@ Der Control-Tarif beginnt bei 9 $ pro aktivem Mitglied und Monat.`,
endDate: 'Enddatum',
autoGeneratedRateTooltip: 'Dieser Satz wurde automatisch erzeugt.',
autoUpdateGovernmentRate: 'Regierungssätze automatisch aktualisieren',
- autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Erstellen Sie automatisch neue Sätze, wenn ${countryPhrase} neue Richtlinien veröffentlicht.`,
+ autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Neue Sätze automatisch erstellen, wenn ${countryPhrase} neue Richtlinien veröffentlicht.`,
governmentRateCountries: {US: 'die Vereinigten Staaten', CA: 'Kanada', GB: 'Großbritannien', AU: 'Australien'},
},
editor: {
@@ -7566,6 +7566,13 @@ Fordern Sie Spesendetails wie Belege und Beschreibungen an, legen Sie Limits und
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>Die öffentliche Belegsichtbarkeit ist nur im Control-Tarif verfügbar, ab <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `pro Mitglied und Monat.` : `pro aktivem Mitglied und Monat.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Regierungssätze automatisch aktualisieren',
+ description:
+ 'Wenn Sie möchten, dass Expensify Ihre Kilometerpauschalen automatisch aktualisiert, sobald Ihre Regierung neue Richtlinien veröffentlicht, ist diese Funktion genau das Richtige für Sie.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>Automatisch aktualisierte amtliche Sätze sind nur im Control-Tarif verfügbar, ab <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `pro Mitglied pro Monat.` : `pro aktivem Mitglied und Monat.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/el.ts b/src/languages/el.ts
index 50f68f02..c89982da 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -7436,7 +7436,7 @@ _Για πιο αναλυτικές οδηγίες, [επισκεφθείτε τ
},
autoGeneratedRateTooltip: 'Αυτός ο συντελεστής δημιουργείται αυτόματα.',
autoUpdateGovernmentRate: 'Αυτόματη ενημέρωση κρατικών συντελεστών',
- autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Δημιουργείτε αυτόματα νέους συντελεστές όταν η ${countryPhrase} δημοσιεύει νέες οδηγίες.`,
+ autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Δημιουργείτε αυτόματα νέες τιμές όταν η ${countryPhrase} δημοσιεύει νέες οδηγίες.`,
governmentRateCountries: {US: 'οι Ηνωμένες Πολιτείες', CA: 'Καναδάς', GB: 'Μεγάλη Βρετανία', AU: 'Αυστραλία'},
},
editor: {
@@ -7823,6 +7823,13 @@ ${reportName}`,
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>Η δημόσια ορατότητα αποδείξεων είναι διαθέσιμη μόνο στο πρόγραμμα Control, με τιμή από <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `ανά μέλος ανά μήνα.` : `ανά ενεργό μέλος ανά μήνα.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Αυτόματη ενημέρωση κρατικών συντελεστών',
+ description:
+ 'Αν θέλετε η Expensify να διατηρεί τις χρεώσεις χιλιομέτρων σας ενημερωμένες κάθε φορά που η κυβέρνησή σας δημοσιεύει νέες οδηγίες, αυτή η δυνατότητα είναι για εσάς.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>Η αυτόματη ενημέρωση κυβερνητικών συντελεστών είναι διαθέσιμη μόνο στο πρόγραμμα Control, ξεκινώντας από <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `ανά μέλος ανά μήνα.` : `ανά ενεργό μέλος ανά μήνα.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/es.ts b/src/languages/es.ts
index b7761818..1c2524a5 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -7147,7 +7147,7 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
startDate: 'Fecha de inicio',
endDate: 'Fecha de fin',
autoGeneratedRateTooltip: 'Esta tasa se genera automáticamente.',
- autoUpdateGovernmentRate: 'Actualiza automáticamente las tasas gubernamentales',
+ autoUpdateGovernmentRate: 'Actualizar automáticamente las tasas gubernamentales',
autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Crea automáticamente nuevas tasas cuando ${countryPhrase} publique nuevas directrices.`,
governmentRateCountries: {US: 'Estados Unidos', CA: 'Canadá', GB: 'Gran Bretaña', AU: 'Australia'},
},
@@ -7538,6 +7538,12 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>La visibilidad pública de recibos solo está disponible en el plan Controlar, desde <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `por miembro al mes.` : `por miembro activo al mes.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Actualizar automáticamente las tasas gubernamentales',
+ description: 'Si quieres que Expensify mantenga tus tasas de kilometraje actualizadas cada vez que tu gobierno publique nuevas directrices, esta función es para ti.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>La actualización automática de tasas gubernamentales solo está disponible en el plan Controlar, desde <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `por miembro al mes.` : `por miembro activo al mes.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index a885fcbf..c0cd2d91 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -7204,7 +7204,7 @@ Le forfait Control commence à 9 $ par Membre actif et par mois.`,
startDate: 'Date de début',
endDate: 'Date de fin',
autoGeneratedRateTooltip: 'Ce taux est généré automatiquement.',
- autoUpdateGovernmentRate: 'Mise à jour automatique des taux gouvernementaux',
+ autoUpdateGovernmentRate: 'Mettre automatiquement à jour les taux gouvernementaux',
autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Créer automatiquement de nouveaux taux lorsque ${countryPhrase} publie de nouvelles directives.`,
governmentRateCountries: {US: 'les États-Unis', CA: 'Canada', GB: 'Grande-Bretagne', AU: 'Australie'},
},
@@ -7590,6 +7590,13 @@ Rendez obligatoires des informations de dépense comme les reçus et les descrip
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>La visibilité publique des reçus est uniquement disponible avec l’offre Control, à partir de <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `par membre et par mois.` : `par membre actif et par mois.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Mettre automatiquement à jour les taux gouvernementaux',
+ description:
+ 'Si vous souhaitez qu’Expensify maintienne vos taux kilométriques à jour dès que votre gouvernement publie de nouvelles directives, cette fonctionnalité est faite pour vous.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>La mise à jour automatique des taux gouvernementaux est uniquement disponible avec l'offre Control, à partir de <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `par membre et par mois.` : `par membre actif et par mois.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 2ae18f5d..fc034a88 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -7533,6 +7533,13 @@ Richiedi dettagli sulle spese come ricevute e descrizioni, imposta limiti e valo
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>La visibilità pubblica delle ricevute è disponibile solo con il piano Control, a partire da <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `per membro al mese.` : `per membro attivo al mese.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Aggiorna automaticamente le aliquote governative',
+ description:
+ 'Se vuoi che Expensify mantenga aggiornate le tue tariffe chilometriche ogni volta che il tuo governo pubblica nuove indicazioni, questa funzionalità fa per te.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>L’aggiornamento automatico delle aliquote governative è disponibile solo con il piano Control, a partire da <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `per membro al mese.` : `per utente attivo al mese.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 2db47c33..674f516f 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -7066,8 +7066,8 @@ Control プランは、アクティブメンバー1人あたり月額 $9 から
startDate: '開始日',
endDate: '終了日',
autoGeneratedRateTooltip: 'このレートは自動生成されています。',
- autoUpdateGovernmentRate: '公的レートを自動更新',
- autoUpdateGovernmentRateDescription: (countryPhrase: string) => `${countryPhrase} が新しいガイダンスを公開したときに、新しいレートを自動的に作成します。`,
+ autoUpdateGovernmentRate: '政府レートを自動更新',
+ autoUpdateGovernmentRateDescription: (countryPhrase: string) => `${countryPhrase} が新しいガイダンスを公表したときに、新しいレートを自動的に作成します。`,
governmentRateCountries: {US: 'アメリカ合衆国', CA: 'カナダ', GB: 'グレートブリテン', AU: 'オーストラリア'},
},
editor: {
@@ -7441,6 +7441,12 @@ ${reportName}`,
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>領収書の公開可視性は、<strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `メンバー1人あたり月額` : `有効メンバー1人あたり1か月ごとに。`}からのControlプランでのみご利用いただけます。</muted-text>`,
},
+ governmentDistanceRates: {
+ title: '政府レートを自動更新',
+ description: '政府が新しいガイダンスを発表するたびに、Expensify にマイレージレートを自動で最新状態に保ってほしい場合に最適な機能です。',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>自動更新される公的レートは、Control プランでのみご利用いただけます(<strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `メンバー1人あたり月額` : `アクティブメンバー1人あたり月額`} から)。</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index ee0a53f1..26f7c3a5 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -7135,7 +7135,7 @@ Het Control-abonnement begint bij $9 per actieve deelnemer per maand.`,
startDate: 'Startdatum',
endDate: 'Einddatum',
autoGeneratedRateTooltip: 'Dit tarief is automatisch gegenereerd.',
- autoUpdateGovernmentRate: 'Automatisch overheidspercentages bijwerken',
+ autoUpdateGovernmentRate: 'Overheidspercentages automatisch bijwerken',
autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Maak automatisch nieuwe tarieven aan wanneer ${countryPhrase} nieuwe richtlijnen publiceert.`,
governmentRateCountries: {US: 'de Verenigde Staten', CA: 'Canada', GB: 'Groot-Brittannië', AU: 'Australië'},
},
@@ -7514,6 +7514,12 @@ Vereis onkostendetails zoals bonnen en beschrijvingen, stel limieten en standaar
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>Publieke bonzichtbaarheid is alleen beschikbaar in het Control-abonnement, vanaf <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `per lid per maand.` : `per actieve deelnemer per maand.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Overheidspercentages automatisch bijwerken',
+ description: 'Als je wilt dat Expensify je kilometertarieven automatisch bijwerkt zodra je overheid nieuwe richtlijnen publiceert, dan is deze functie iets voor jou.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>Automatisch bijwerken van overheidspercentages is alleen beschikbaar in het Control-abonnement, vanaf <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `per lid per maand.` : `per actief lid per maand.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 194f0a7a..8bb2ddaa 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -7116,7 +7116,7 @@ Plan Control zaczyna się od 9 USD za aktywnego członka miesięcznie.`,
endDate: 'Data zakończenia',
autoGeneratedRateTooltip: 'Ta stawka jest generowana automatycznie.',
autoUpdateGovernmentRate: 'Automatycznie aktualizuj stawki rządowe',
- autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Automatycznie twórz nowe stawki, gdy ${countryPhrase} opublikuje nowe wytyczne.`,
+ autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Automatycznie twórz nowe stawki, gdy ${countryPhrase} publikuje nowe wytyczne.`,
governmentRateCountries: {US: 'Stany Zjednoczone', CA: 'Kanada', GB: 'Wielka Brytania', AU: 'Australia'},
},
editor: {
@@ -7498,6 +7498,13 @@ Wymagaj szczegółów wydatków, takich jak paragony i opisy, ustawiaj limity i
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>Publiczna widoczność rachunków jest dostępna tylko w planie Control, zaczynającym się od <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `za członka miesięcznie.` : `za aktywnego członka miesięcznie.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Automatycznie aktualizuj stawki rządowe',
+ description:
+ 'Jeśli chcesz, żeby Expensify automatycznie aktualizował twoje stawki za przejazdy za każdym razem, gdy twój rząd opublikuje nowe wytyczne, ta funkcja jest dla ciebie.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>Automatyczna aktualizacja stawek rządowych jest dostępna tylko w planie Control, od <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `za użytkownika miesięcznie.` : `na aktywnego członka za miesiąc.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 304b899a..fcd30563 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -7137,9 +7137,9 @@ O plano Control começa em US$ 9 por membro ativo por mês.`,
startDate: 'Data de início',
endDate: 'Data de término',
autoGeneratedRateTooltip: 'Essa tarifa é gerada automaticamente.',
- autoUpdateGovernmentRate: 'Atualizar automaticamente as taxas governamentais',
+ autoUpdateGovernmentRate: 'Atualizar automaticamente taxas governamentais',
autoUpdateGovernmentRateDescription: (countryPhrase: string) => `Crie automaticamente novas taxas quando ${countryPhrase} publicar novas orientações.`,
- governmentRateCountries: {US: 'Estados Unidos', CA: 'Canadá', GB: 'Reino Unido', AU: 'Austrália'},
+ governmentRateCountries: {US: 'Estados Unidos', CA: 'Canadá', GB: 'Grã-Bretanha', AU: 'Austrália'},
},
editor: {
descriptionInputLabel: 'Descrição',
@@ -7516,6 +7516,13 @@ Exija dados de despesas como recibos e descrições, defina limites e padrões e
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>A visibilidade pública de recibos está disponível apenas no plano Control, a partir de <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `por membro por mês.` : `por membro ativo por mês.`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: 'Atualizar automaticamente taxas governamentais',
+ description:
+ 'Se você quer que o Expensify mantenha suas tarifas de quilometragem sempre atualizadas sempre que o governo publicar novas orientações, este recurso é para você.',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>A atualização automática de taxas governamentais só está disponível no plano Control, a partir de <strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `por membro por mês.` : `por membro ativo por mês.`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 393365c1..97354659 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -7263,6 +7263,12 @@ ${reportName}`,
onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
`<muted-text>公开收据可见性仅适用于 Control 方案,起价为<strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `每位成员每月。` : `每位活跃成员每月。`}</muted-text>`,
},
+ governmentDistanceRates: {
+ title: '自动更新政府费率',
+ description: '如果你希望在政府发布新的指引时,Expensify 自动为你更新里程费率,那么此功能正适合你。',
+ onlyAvailableOnPlan: ({formattedPrice, hasTeam2025Pricing}: {formattedPrice: string; hasTeam2025Pricing: boolean}) =>
+ `<muted-text>自动更新政府费率仅适用于 Control 方案,起价为<strong>${formattedPrice}</strong> ${hasTeam2025Pricing ? `每位成员每月。` : `每位活跃成员每月。`}</muted-text>`,
+ },
},
downgrade: {
commonFeatures: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
|
That video looks good to me. Is that all you need from us, or was there something else? |
Yeah that's it, thanks! |
|
🚧 neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.59-0 🚀
|
|
Deploy Blocker #99268 was identified to be related to this PR. |
|
Deploy Blocker #99269 was identified to be related to this PR. |
|
Deploy Blocker #99282 was identified to be related to this PR. |
|
Deploy Blocker #99285 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.4.59-5 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Fixed Issues
$ #95281
PROPOSAL:
Tests
Prerequisites
Distance unit correction
Unsupported currency
Failure path
Offline tests
QA Steps
Same as tests
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android_hybrid.mp4
Android: mWeb Chrome
android_mWeb.mp4
iOS: Native
ios_hybrid.mp4
iOS: mWeb Safari
ios_mWeb.mp4
MacOS: Chrome / Safari
web_chrome.mp4