Android - Workspace - Brief Error Blink Before Opening Company Cards - #98003
Android - Workspace - Brief Error Blink Before Opening Company Cards#98003lorretheboy wants to merge 4 commits into
Conversation
|
@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a5ddc282ff
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
The code change is fine. Testing it out. |
|
@lorretheboy I've been testing this on Android and Web too. When we create a workspace for the first time there's a small flicker before the loader shows up. Steps to reproduce:
web-loader-company-cards.mov |
|
Thanks for reviewing @mananjadhav. I will recheck it today and give you update |
|
Hello @mananjadhav, I'm still finding solution for this, I will keep you update daily for the issue |
|
@mananjadhav I fixed the glitch, could you please check again? Screen.Recording.2026-08-12.at.15.22.26.mov |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-company-card-loader.movAndroid: mWeb Chromemweb-chrome-company-card-loader.moviOS: HybridAppios-company-card-loader.moviOS: mWeb Safarimweb-safari-company-card-loader.movMacOS: Chrome / Safariweb-company-card-loader.mov |
MonilBhavsar
left a comment
There was a problem hiding this comment.
Looks good otherwise
| policyID: string; | ||
|
|
||
| /** Whether the policy is loaded */ | ||
| /** Whether the policy is fully loaded, i.e. its account ID has resolved */ |
There was a problem hiding this comment.
This is true for the offline case, when it's not fully loaded, right?
May be we clarify that in the comment
Explanation of Change
Fixed Issues
$ #94983
PROPOSAL: #94983 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)Avatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-07.at.01.19.35.mov
Android: mWeb Chrome
Screen.Recording.2026-08-07.at.01.22.53.mov
iOS: Native
Screen.Recording.2026-08-07.at.01.25.56.mov
iOS: mWeb Safari
Screen.Recording.2026-08-07.at.01.24.38.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-07.at.01.23.38.mov