fix: Pay button is shown for expense creator in 1:1 chat after visiting Spend tab - #98260
Conversation
|
@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
Will start reviewing today. |
|
@nkdengineer could you please resolve the conflicts? |
|
@Krishna2323 I updated. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid_hynrid.mp4Android: mWeb Chromeandroid_mWeb.mp4iOS: HybridAppios_hybrid.mp4iOS: mWeb Safariios_mWeb.mp4MacOS: Chrome / Safariweb_chrome.mp4 |
|
@nkdengineer please merge main. @MariaHCD I think you forgot to merge this one 😅 |
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
Co-authored-by: Nikki Wines <nikkiwines@expensify.com>
|
@NikkiWines I updated. |
|
🚧 MariaHCD has triggered a test Expensify/App build. You can view the workflow run here. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/MariaHCD in version: 9.4.57-0 🚀
|
|
🤖 No help site changes required. This PR is a narrow bug fix, not a behavior or feature change. It adds an This restores the already-expected behavior (only the actual payer sees Pay in that flow) and introduces no new feature, setting, label, tab, or user-facing workflow. Nothing in Because no changes are required, I have not created a draft help site PR. @nkdengineer, if you believe a help site article should be added or updated for this behavior, let me know and I'll create the draft PR. |
|
🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
fix: Pay button is shown for expense creator in 1:1 chat after visiting Spend tab
Fixed Issues
$ #95882
PROPOSAL: #95882 (comment)
Tests
Viewgray button is still shownOffline tests
QA Steps
Same as test
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2026-08-11.at.14.29.54.mov
Android: mWeb Chrome
Screen.Recording.2026-08-11.at.14.29.09.mov
iOS: Native
Screen.Recording.2026-08-11.at.14.31.38.mov
iOS: mWeb Safari
Screen.Recording.2026-08-11.at.14.30.40.mov
MacOS: Chrome / Safari
Screen.Recording.2026-08-11.at.14.27.12.mov