-
Notifications
You must be signed in to change notification settings - Fork 4k
Move multi-level tag Required from the Tags table to Rules #98414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
JS00001
merged 23 commits into
Expensify:main
from
Krishna2323:krishna2323/issue-95764-multilevel-tag-required
Aug 18, 2026
+330
−57
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
e6b23f4
Move multi-level tag Required from the Tags table to Rules
Krishna2323 3b046d9
add lock to tags toggle and load tags.
Krishna2323 62ceef3
Name required tag lists in the Require fields row description
Krishna2323 c00ff16
remove comment.
Krishna2323 4476c30
Update tag toggle tests for per-level Required
Krishna2323 da3048f
add margin bottom to custom tag name row.
Krishna2323 bedf44f
Track only edited tag levels and guard the last required one
Krishna2323 1e013bd
Narrow the hasChanges dependency and drop redundant memos in the rule…
Krishna2323 9a807b9
fetch tags on general tab.
Krishna2323 507cc6d
Stop an accounting connection from locking tag Required
Krishna2323 fd3eb4b
remove comment.
Krishna2323 8ca53c1
Merge branch 'Expensify:main' into krishna2323/issue-95764-multilevel…
Krishna2323 369f2de
Merge branch 'Expensify:main' into krishna2323/issue-95764-multilevel…
Krishna2323 a6c755e
Merge branch 'Expensify:main' into krishna2323/issue-95764-multilevel…
Krishna2323 8a564b1
Fix per-level tag Required toggles to write one list at a time
Krishna2323 fa0ec85
Fix per-level tag Required toggles to write one list at a time
Krishna2323 ba96c54
Recompute tag violations once for a mixed require/unrequire save
Krishna2323 7b17f18
Extract hasPerTagListRequired and getTagListLabel helpers
Krishna2323 0355e5f
Merge branch 'Expensify:main' into krishna2323/issue-95764-multilevel…
Krishna2323 fac7f35
align rules page toggles to flex start.
Krishna2323 ccfea93
Fix optimistic tag and category violations on the Require fields page
Krishna2323 1b7ef47
Clear Required on tag levels with no enabled tags
Krishna2323 a4d317a
remove useCallback and useMemo
Krishna2323 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.