Skip to content

[No QA] Cleanup CLAUDE.md #98514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roryabraham merged 3 commits into from
Aug 13, 2026
+4 −5
Merged

[No QA] Cleanup CLAUDE.md #98514

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a04bf87
Dummy change
roryabraham Aug 13, 2026
9cb059e
Merge branch 'main' into rory-test
roryabraham Aug 13, 2026
4dc7aa2
Drop Oxfmt from pre-commit claude since it's a commit hook now
roryabraham Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,10 +225,9 @@ React Compiler auto-memoizes object literals, callbacks, JSX, and derived values

**ALWAYS run these steps after making code changes, before committing:**

1. **Oxfmt**: Run `npm run fmt` on every file you modified. This is mandatory - CI will reject unformatted code.

@roryabraham roryabraham Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oxfmt happens in a pre-commit hook now, so claude doesn't need to do it manually.

2. **ESLint**: Run `npm run lint-changed` to catch lint errors early.
3. **TypeScript**: Run `npm run typecheck-tsgo` after changes that may affect typing (types, interfaces, or function signatures). It is ~10x faster and usually stricter than tsc. CI validates with `npm run typecheck` (tsc), which remains the required merge gate.
4. **React Compiler**: If you added new React components/hooks or modified existing ones, run `npm run react-compiler-compliance-check check-changed` to verify they compile with React Compiler. This applies the same rules as CI, evaluated against BOTH the Babel and OXC compilers: new components/hooks must compile, existing compiled files must not regress, and changes must not introduce new memoization divergence (one compiler memoizing a file while the other does not). See `contributingGuides/REACT_COMPILER.md` for details and common fixes.
1. **ESLint**: Run `npm run lint-changed` to catch lint errors early.
2. **TypeScript**: Run `npm run typecheck-tsgo` after changes that may affect typing (types, interfaces, or function signatures). It is ~10x faster and usually stricter than tsc. CI validates with `npm run typecheck` (tsc), which remains the required merge gate.
3. **React Compiler**: If you added new React components/hooks or modified existing ones, run `npm run react-compiler-compliance-check check-changed` to verify they compile with React Compiler. This applies the same rules as CI, evaluated against BOTH the Babel and OXC compilers: new components/hooks must compile, existing compiled files must not regress, and changes must not introduce new memoization divergence (one compiler memoizing a file while the other does not). See `contributingGuides/REACT_COMPILER.md` for details and common fixes.

### Testing

Expand Down Expand Up @@ -357,6 +356,6 @@ Use the `/agent-device` skill to drive the App on iOS and Android (simulators or

### With Backend Services

- RESTful API communication
- REST API communication
- WebSocket connections via Pusher
- Real-time synchronization
Loading