[No QA] Fix unsafe type assertions in tests

[KJ21-ENG]

Explanation of Change

Removes unsafe type assertions and assertion-equivalent test scaffolding across 15 test files while preserving their existing fixtures, mocks, UI expectations, and behavior. A single reserved test helper, tests/utils/mockReanimatedModal.tsx, centralizes the repeated Reanimated modal mock needed by the cleaned tests.

Fixed Issues

$ #94739
PROPOSAL: #94739 (comment)

Count change

Current baseline source:

• config/eslint/eslint.seatbelt.tsv at base c926b19748f5335a15809a0c14274c2e9f5e7aac.

Before:

• tests/ui/WorkspaceCategoriesTest.tsx: 2 violations
• tests/ui/WorkspaceMoreFeaturesPageTest.tsx: 2 violations
• tests/ui/WorkspaceTagsTest.tsx: 2 violations
• tests/ui/WorkspaceUpgradeTest.tsx: 2 violations
• tests/ui/WorkspaceWorkflowsPayerRowTest.tsx: 2 violations
• tests/ui/YearListItemHeaderTest.tsx: 2 violations
• tests/unit/AvatarUtilsTest.ts: 2 violations
• tests/unit/BulletListRendererTest.tsx: 2 violations
• tests/unit/ButtonStyleUtilsTest.ts: 2 violations
• tests/unit/ExpenseRuleUtilsTest.ts: 2 violations
• tests/unit/FraudProtectionTest.ts: 2 violations
• tests/unit/components/reportDetails/DynamicReportDetailsPageTest.tsx: 2 violations
• tests/unit/compoundParamsKeyTest.ts: 2 violations
• tests/unit/deferredLayoutWriteTest.ts: 2 violations
• tests/unit/hooks/confirmAction.test.ts: 2 violations

After:

• tests/ui/WorkspaceCategoriesTest.tsx: 0 violations
• tests/ui/WorkspaceMoreFeaturesPageTest.tsx: 0 violations
• tests/ui/WorkspaceTagsTest.tsx: 0 violations
• tests/ui/WorkspaceUpgradeTest.tsx: 0 violations
• tests/ui/WorkspaceWorkflowsPayerRowTest.tsx: 0 violations
• tests/ui/YearListItemHeaderTest.tsx: 0 violations
• tests/unit/AvatarUtilsTest.ts: 0 violations
• tests/unit/BulletListRendererTest.tsx: 0 violations
• tests/unit/ButtonStyleUtilsTest.ts: 0 violations
• tests/unit/ExpenseRuleUtilsTest.ts: 0 violations
• tests/unit/FraudProtectionTest.ts: 0 violations
• tests/unit/components/reportDetails/DynamicReportDetailsPageTest.tsx: 0 violations
• tests/unit/compoundParamsKeyTest.ts: 0 violations
• tests/unit/deferredLayoutWriteTest.ts: 0 violations
• tests/unit/hooks/confirmAction.test.ts: 0 violations

Net reduction:

• 30 fewer unsafe type assertion violations.

TSV evidence:

• The verifier restored config/eslint/eslint.seatbelt.tsv byte-for-byte after confirming zero cleanup findings in every target and the reserved support path.

Tests

1. Focused formatter and ESLint passed for all 16 changed files.
2. Focused Jest passed for the exact cleanup target set.
3. git diff --check, changed-path proof, and generated-TSV restoration passed.
4. Independent scope, type-safety, and regression reviews were clean.
5. Exact-head Fork CI passed typecheck, lint, format, React Compiler, and Jest at signed commit 9ed615a6ee8e87422ff5a5ddd8a848db94caaa0f.

N/A: this is test-only cleanup with no manual application flow or JS-console behavior to exercise.

Offline tests

N/A: this test-only cleanup does not change networking, offline behavior, or application runtime behavior.

QA Steps

N/A: the [No QA] title is appropriate because this change only removes unsafe type assertions from tests and consolidates repeated test-only mock setup, with focused verification and exact-head CI coverage.

PR Author Checklist

N/A rationale: manual platform, high-traffic-account, screenshots, assets, CSS, UI, copy, deeplink, Storybook, messaging, generic-component, feature/bug-flow, and post-review-main-merge checks do not apply because this PR changes only test code, introduces no product behavior, and has not merged main after review. The applicable automated checks and independent reviews are recorded above. Every item below was considered against that scope.

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

N/A: no UI or runtime application behavior changed.

Changed files (16)

• tests/ui/WorkspaceCategoriesTest.tsx
• tests/ui/WorkspaceMoreFeaturesPageTest.tsx
• tests/ui/WorkspaceTagsTest.tsx
• tests/ui/WorkspaceUpgradeTest.tsx
• tests/ui/WorkspaceWorkflowsPayerRowTest.tsx
• tests/ui/YearListItemHeaderTest.tsx
• tests/unit/AvatarUtilsTest.ts
• tests/unit/BulletListRendererTest.tsx
• tests/unit/ButtonStyleUtilsTest.ts
• tests/unit/ExpenseRuleUtilsTest.ts
• tests/unit/FraudProtectionTest.ts
• tests/unit/components/reportDetails/DynamicReportDetailsPageTest.tsx
• tests/unit/compoundParamsKeyTest.ts
• tests/unit/deferredLayoutWriteTest.ts
• tests/unit/hooks/confirmAction.test.ts
• tests/utils/mockReanimatedModal.tsx (reserved support path)

[KJ21-ENG]

@ikevin127 Could you please take a look at this when you get a chance? Thanks!

[melvin-bot]

@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]