Bring back Top merchants insight to the Home page - #98557
Conversation
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
🚧 mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppIMG_2794.MP4Android: mWeb Chrome2026-08-13.12.36.28.moviOS: HybridAppIMG_2794.MP4iOS: mWeb Safari2026-08-13.12.36.28.movMacOS: Chrome / Safari2026-08-13.12.35.32.mov |
|
Jest issue is not related to this PR |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.4.54-0 🚀
|
Help site review — no changes requiredI reviewed this PR against the help site articles in What this PR does: re-adds the Top merchants option to the Insights/charts dropdown on Home ( Why no docs update is needed:
This PR restores previously-shipped, already-documented behavior and introduces no new user-facing feature, terminology, or label, so the help site is already accurate. No draft docs PR was created since there's nothing to change. UI verification noteI attempted to confirm the exact dropdown labels on the live Home page, but the test account has no workspaces (the charts section only renders for an admin/auditor/approver of a paid workspace with expenses across ≥2 months), so the section didn't appear. The conclusion above relies on the existing docs already using the correct label and this being a restoration of prior documented behavior rather than a new feature. @mhawryluk, there's no help site PR to review here — the Top Merchants insight is already documented and this PR just restores it on Home. If you think a specific article should still be updated (e.g. calling out the Home dropdown options explicitly), let me know and I'll open a draft docs PR. |
Explanation of Change
Adds the "Top merchants" option to the Insights section's dropdown on the Home page again.
Originally added here: #96625
Removed here: #98354
Because the pie charts were crashing on release builds: #98331
Which has been fixed here: #98437
Fixed Issues
$ #96464
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari