Skip to content

Add August product marketing window - #98565

Merged
Julesssss merged 12 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/98233-august-product-marketing-window
Aug 19, 2026
Merged

Add August product marketing window#98565
Julesssss merged 12 commits into
Expensify:mainfrom
KJ21-ENG:KJ21-ENG/98233-august-product-marketing-window

Conversation

@KJ21-ENG

@KJ21-ENG KJ21-ENG commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

Replaces the July product marketing announcement with the August admin and eligible member variants and their supplied images. The admin CTA uses the selected admin workspace's hydrated accounting connections to route to Vendors when enabled, or safely falls back to More Features while offline or after a failed connection refresh. Members with Custom Agent access can open the new Agents flow without bypassing its beta boundary. Dismissal remains campaign-keyed and is persisted before navigation.

Fixed Issues

$ #98233
PROPOSAL: #98233 (comment)

Tests

  1. Verify that no errors related to ProductMarketingWindow appear in the JS console.
  2. Sign in with a fresh member account that has Custom Agent beta access and is not an admin of any active workspace.
  3. Verify the Pre-built agents for you window appears with the employee image and Dismiss / Try it out actions.
  4. Press Try it out, verify the new Agents page opens, and verify the window is dismissed before navigation and does not reappear after reload.
  5. Remove Custom Agent beta access from the member account and verify the member window is not shown.
  6. Sign in with an admin account whose selected admin workspace does not have Vendors enabled.
  7. Verify the Enhanced vendor mapping window appears with the admin image, then press Try it out and verify the workspace More Features page opens.
  8. Repeat with a workspace that has the Vendor Matching beta and a supported accounting connection configured.
  9. Verify Try it out opens that workspace's Vendors page after its connection data finishes loading.
  10. Make a non-admin workspace active while the account administers another active workspace. Verify the CTA stays disabled while the fallback workspace's connections load, then routes using the fallback admin workspace.
  11. Dismiss the window, reload, and verify the August window stays dismissed. With an account whose last dismissed campaign is July, verify the August window still appears.
  • Verify that no errors related to ProductMarketingWindow appear in the JS console

Offline tests

  1. Use an admin account where the active workspace is not administered but another active workspace is.
  2. Go offline before the fallback workspace's accounting connections are fetched.
  3. Verify the admin CTA remains actionable and opens More Features instead of assuming Vendors is enabled or showing an error.
  4. Restore the network, let the connection data load, and verify the destination follows the workspace's actual Vendors state.

QA Steps

  1. Repeat Tests 1-11 on staging with fresh member and admin accounts, including member accounts with and without Custom Agent beta access.
  2. For the direct Vendors case, use an admin workspace with Vendor Matching beta access and a supported accounting connection.
  3. Verify the fallback More Features destination remains visible and actionable for the intended campaign recipient; enabling Vendors is tracked separately from this PR.
  4. Repeat the Offline tests and verify no incorrect Vendors destination or error page appears.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Record_2026-08-16-03-39-38_40d2c9e2d8fb5b5aba3904834590021e.compressed.mp4
Android: mWeb Chrome
Record_2026-08-15-12-10-46.mp4
iOS: Native
Simulator.Screen.Recording.-.iPhone.17.-.2026-08-15.at.17.24.55.compressed.mp4
iOS: mWeb Safari
Simulator.Screen.Recording.-.iPhone.17.-.2026-08-15.at.14.26.29.compressed.mp4
MacOS: Chrome / Safari

Pre-review POC evidence from the earlier candidate. This does not replace final-head, all-platform recordings.

Member marketing window:

Member marketing window

Admin marketing window:

Admin marketing window

More Features fallback:

More Features fallback

Direct Vendors destination:

Direct Vendors destination

Video:

Screen.Recording.2026-08-13.at.11.43.16.AM.compressed.mp4

@melvin-bot

melvin-bot Bot commented Aug 13, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@KJ21-ENG
KJ21-ENG marked this pull request as ready for review August 15, 2026 22:23
@KJ21-ENG
KJ21-ENG requested review from a team as code owners August 15, 2026 22:23
@melvin-bot
melvin-bot Bot requested review from a team, huult and joekaufmanexpensify and removed request for a team August 15, 2026 22:23
@melvin-bot

melvin-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot
melvin-bot Bot requested review from garrettmknight and removed request for a team August 15, 2026 22:23
@melvin-bot

melvin-bot Bot commented Aug 15, 2026

Copy link
Copy Markdown

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

  1. Look at the code and make sure there are no malicious changes.
  2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

@codecov

codecov Bot commented Aug 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
.../ProductMarketingWindow/ProductMarketingWindow.tsx 100.00% <100.00%> (ø)
src/libs/ProductMarketingWindowUtils.ts 100.00% <100.00%> (ø)
...tMarketingWindow/ProductMarketingWindowManager.tsx 97.67% <90.90%> (-2.33%) ⬇️
... and 346 files with indirect coverage changes

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Screenshots and videos look good to me 👍

@shawnborton

Copy link
Copy Markdown
Contributor

Video looks good to me. In the future, it might be nice to have a little spinner while the image loads:
CleanShot 2026-08-16 at 20 15 52@2x

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Great shout 👍 I like that idea. Would be nice to make a follow-up on that now cause we'll keep updating this each month I assume?

@shawnborton

Copy link
Copy Markdown
Contributor

Yup that makes sense. @KJ21-ENG thoughts on the idea before I make an issue?

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

@shawnborton I loved the idea, as it had seemed off to me since last month when I was working on implementing this marketing window. All this time I had been thinking about how to make it load faster😅, but the spinner now makes more sense to me as well :)

cc: @dubielzyk-expensify

@huult

huult commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

@shawnborton @dubielzyk-expensify Do you need an ad hoc build to test?

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Thoughts ?

Screen.Recording.2026-08-17.at.10.14.49.AM.compressed.mp4

cc: @shawnborton @dubielzyk-expensify @huult

@dubielzyk-expensify

Copy link
Copy Markdown
Contributor

Thoughts ?

That looks good.

@shawnborton @dubielzyk-expensify Do you need an ad hoc build to test?

I'll kick one off

@github-actions

Copy link
Copy Markdown
Contributor

🚧 dubielzyk-expensify has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions

This comment has been minimized.

@KJ21-ENG

KJ21-ENG commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

@Julesssss Thank you! @KJ21-ENG, please apply this.

@huult Done! f2b6499

@huult

huult commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

@Julesssss Thank you! @KJ21-ENG, please apply this.

@huult Done! f2b6499

thanks, @JS00001 all yours

@JS00001

JS00001 commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

looks like @Julesssss is assigned to this one, lmk if you want a second review!

@Julesssss
Julesssss merged commit 1cf39b4 into Expensify:main Aug 19, 2026
36 of 37 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 Julesssss has triggered a test Expensify/App build. You can view the workflow run here.

@OSBotify

Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@huult

huult commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

looks like @Julesssss is assigned to this one, lmk if you want a second review!

Sorry, wrong tag 😅 I typed J first and hit Enter =]]

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.4.57-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 I reviewed the changes in this PR against Expensify's help site files under docs/articles, and no help site changes are required. I did not create a draft docs PR.

Why no docs changes are needed:

This PR updates the in-app product marketing window — a transient promotional pop-up that replaces the July announcement with the August admin ("Enhanced vendor mapping") and eligible-member ("Pre-built agents for you") variants, refreshes its copy and images, and adds CTA routing/loading logic.

  • These ephemeral marketing announcement windows are not documented on the help site — a search of docs/articles for the window, its campaign keys, and promo image names returns nothing. The help site documents how features work, not the in-app promos that surface them.
  • The two features the CTAs point to already have help articles, and this PR doesn't change how either behaves:

Since the change is limited to the marketing window UI, copy, assets, and CTA routing — and the destination features are already documented — there's nothing to add or update in the help site.

@KJ21-ENG, if you believe a specific behavior surfaced here should be reflected in a help article, let me know which one and I'll draft the docs PR.


view run

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #99027 was identified to be related to this PR.

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Deploy Blocker #99027 was identified to be related to this PR.

Looking into this 👀

@KJ21-ENG

KJ21-ENG commented Aug 20, 2026

Copy link
Copy Markdown
Contributor Author

Replied here.

@mitarachim

Copy link
Copy Markdown

Deploy Blocker #99034 was identified to be related to this PR.

@izarutskaya

Copy link
Copy Markdown

@KJ21-ENG Could you please clarify the steps, what account should we use for this PR ?

Verify that no errors related to ProductMarketingWindow appear in the JS console.
Sign in with a fresh member account that has Custom Agent beta access and is not an admin of any active workspace.

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

@izarutskaya Point 2 and 6 may help you to understand it. Tell me if they are not helpful, I will explain it

@izarutskaya

Copy link
Copy Markdown

@KJ21-ENG I see this ProductMarketingWindow when log in with fresh expensifail account. It's not expected, right?

image

@izarutskaya

Copy link
Copy Markdown

According step 8, after creating a new Expensifail account with a QBO-connected workspace, the August product marketing modal did not appear. Could you please take a look at this and let me know?

Step.8.fails.mp4

Also, how can we check on step 11, if an account dismissed the July campaign modal? Thank you

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

@KJ21-ENG I see this ProductMarketingWindow when log in with fresh expensifail account. It's not expected, right?

image

@izarutskaya This is expected for this account. The member window appears when the account has Custom Agent beta access and is not an admin of any active workspace. The Agents option visible in your screenshot indicates that the account has the required access, so you can use this account for steps 2–5.

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

According step 8, after creating a new Expensifail account with a QBO-connected workspace, the August product marketing modal did not appear. Could you please take a look at this and let me know?

Step.8.fails.mp4
Also, how can we check on step 11, if an account dismissed the July campaign modal? Thank you

@izarutskaya Could you confirm whether this account previously dismissed or pressed Try it out on the member window? The member and admin windows belong to the same August campaign, so interacting with either one dismisses the August campaign for that account. Please use a separate fresh admin account for step 8.

You can check the campaign dismissal value on staging by running this in DevTools:

window.Onyx.get('nvp_lastDismissedMarketingWindow').then(console.log)

  • productUpdateAugust2026 means the August campaign was already dismissed, so the window should not appear.
  • productUpdateJuly2026 means only July was dismissed, so the August window should still appear.
  • An empty or undefined value means no campaign was dismissed.

For step 11, please use an older account that returns productUpdateJuly2026, then reload and verify that the August window appears. If a separate eligible admin account returns July or an empty value but the August window still does not appear, please share that value and we’ll investigate further.

@izarutskaya

Copy link
Copy Markdown

@KJ21-ENG Issue from step 8 is still reproducible. Also, the modal was not dismissed in the previous testing

Repro.-.Step.8.fails.mp4

Probably snippet isn’t working. Could you please check and let me know if we doing this correctly?

snippet.not.working.mp4

@KJ21-ENG

Copy link
Copy Markdown
Contributor Author

Thanks, I reviewed both recordings and ran a separate control test on staging.

I've attached a recording from a different fresh synthetic admin account. It shows the account selecting QuickBooks Online during onboarding, creating an owned workspace, and then receiving the Enhanced vendor mapping window. On that account, the direct awaited dismissal value was undefined.

This recording does not reproduce your complete QBO-connected and Vendors-enabled setup, so it does not invalidate your report. It only confirms that the marketing window is not globally missing for every fresh admin account. The reason it remains absent on your specific account is still unresolved.

The diagnostic shown in your recording is ambiguous because .then(console.log) returns a Promise whose final value is always undefined, since console.log() itself returns undefined. Please hard reload and run this directly:

await window.Onyx.get('nvp_lastDismissedMarketingWindow')

Please share the literal result displayed on the next line:

  • productUpdateAugust2026 means the August campaign is already stored as dismissed.
  • undefined, empty, or productUpdateJuly2026 means the August window should still be eligible.

If the value is not productUpdateAugust2026 and the window remains absent, please also run this and share the returned object:

const [dismissed, isLoadingApp, isCovered, session, account, modal] = await Promise.all([
    window.Onyx.get('nvp_lastDismissedMarketingWindow'),
    window.Onyx.get('isLoadingApp'),
    window.Onyx.get('isProductMarketingWindowCovered'),
    window.Onyx.get('session'),
    window.Onyx.get('account'),
    window.Onyx.get('modal'),
]);

({
    dismissed,
    isLoadingApp,
    isCovered,
    isAnonymous: session?.authTokenType === 'anonymous',
    isActingAsDelegate: Boolean(account?.delegatedAccess?.delegate),
    needsTwoFactorAuthSetup: account?.needsTwoFactorAuthSetup,
    requiresTwoFactorAuth: account?.requiresTwoFactorAuth,
    twoFactorAuthSetupInProgress: account?.twoFactorAuthSetupInProgress,
    modalVisible: Boolean(modal?.isVisible),
    path: location.pathname,
});

That result should identify which account-specific visibility gate is suppressing the window.

pr-98565-step8-fresh-admin-visibility.mp4

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.