fix: chart glyph fallback for currency symbols missing from the display font by luacmartins · Pull Request #98621 · Expensify/App

luacmartins · 2026-08-13T20:52:53Z

Explanation of Change

Concierge donut chart's "Total" label used the Expensify New Kansas font, which lacks the Vietnamese dong glyph (₫, U+20AB), rendering incorrectly. Skia draws chart text with a single typeface and no CSS-style font fallback, so a missing glyph never substitutes.

getChartSkiaTypeface now checks if the resolved typeface can render the given text and swaps to Expensify Neue Bold if not. Wired into all VictoryChartRenderer text draw/measure sites (label, legend, pie label layout).

Fixed Issues

$ #97341

Tests

Open Concierge chat in a workspace with expenses in VND.
Ask "expenses broken down by category".
Verify the donut chart's center total renders ₫ correctly.
Verify slice labels/legend still render correctly (no regression).
Repeat with USD, verify no visual regression.
npm run server:vcr:test passes.

Verify that no errors appear in the JS console

Offline tests

N/A feature doesn't work offline

QA Steps

Open Concierge chat in a workspace with expenses in VND.
Ask "expenses broken down by category".
Verify the donut chart's center total renders ₫ correctly (no tofu box).

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Expensify New Kansas (headline font) doesn't include the Vietnamese dong glyph (U+20AB), so VND totals rendered as tofu boxes. Neue (body font) has full glyph coverage and is already used for the chart legend without issue.

The Concierge chart is rendered via VictoryChartRenderer's Skia canvas drawing (client HTML renderer + headless victory-chart-renderer CLI), not the client-side PieChartContent component. Skia's Font/SkText draw with a single concrete typeface and never fall back to another font for a missing glyph, unlike CSS. The chart XML's "Total" label uses Expensify New Kansas, which doesn't include the Vietnamese dong glyph (U+20AB), so it rendered as a tofu box. getChartSkiaTypeface now accepts the text being rendered and swaps to a typeface with broader glyph coverage (Expensify Neue Bold) when the resolved typeface can't render it, fixing this for any currency symbol across all VictoryChartRenderer text draws (labels, pie labels, legend), not just VND.

…rals

… table

# Conflicts: # tests/unit/getChartSkiaTypefaceTest.ts

melvin-bot · 2026-08-13T21:59:11Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2026-08-13T22:03:07Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
.../components/Charts/utils/chartTypefaceFallbacks.ts	`100.00% <100.00%> (ø)`
...rc/components/Charts/utils/getChartSkiaTypeface.ts	`100.00% <100.00%> (ø)`
...toryChartRenderer/components/VictoryChartLabel.tsx	`0.00% <0.00%> (ø)`
...oryChartRenderer/components/VictoryChartLegend.tsx	`0.00% <0.00%> (ø)`
...ictoryChartRenderer/utils/computePieLabelLayout.ts	`74.28% <0.00%> (ø)`
... and 9 files with indirect coverage changes

shawnborton · 2026-08-14T00:19:12Z

Nice!

garrettmknight

Looks good from a product perspective

…magic control-char threshold canTypefaceRenderText contained "cant" (from "canT..."), tripping the no-negated-variables ESLint rule. Renamed to typefaceCanRenderText. Also extracted the 0x20 control-character threshold into a named constant with an explanatory comment per review feedback.

Ollyws · 2026-08-18T08:13:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

luacmartins · 2026-08-18T20:21:25Z

@Ollyws are you still testing this one?

Ollyws · 2026-08-18T21:09:39Z

Yeah almost done.

Ollyws

LGTM.

melvin-bot · 2026-08-19T13:49:59Z

@NicolasBonet Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

NicolasBonet · 2026-08-19T14:29:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

OSBotify · 2026-08-19T14:35:59Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-08-19T14:38:05Z

🚧 NicolasBonet has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-08-19T14:43:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #98621.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-ab8ebaa-155b898-91e22179e861430d54c975877f5a2f4bbe59046d/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-ab8ebaa-155b898-445c97e5f3519c90dd372042b54acc63ef059b2a/index.html

Web 🕸️
https://98621.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-08-20T04:29:15Z

🚀 Deployed to staging by https://github.com/NicolasBonet in version: 9.4.57-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-08-20T04:32:28Z

🤖 No help site changes required.

This PR is an internal rendering bug fix: getChartSkiaTypeface now falls back to Expensify Neue Bold when the resolved typeface can't render a glyph (e.g. the Vietnamese dong ₫), so Concierge chart labels no longer show tofu boxes. It adds no feature, changes no UI/button/tab/setting/label, and alters no user-facing steps — it just makes existing chart text render correctly.

The only related article, How-Concierge-Analyzes-Spend.md, documents what Concierge spend charts do, not how glyphs are rendered, so nothing there needs updating.

No draft PR was created.

view run

jponikarchuk · 2026-08-20T11:36:04Z

This PR failing in offline mode because of the issue #99060
This issue is reproducible in: All platforms

luacmartins · 2026-08-20T15:31:10Z

@jponikarchuk that's expected. That feature doesn't work offline. I updated the offline test section to reflect that.

OSBotify · 2026-08-21T00:54:52Z

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android

melvin-bot Bot assigned luacmartins Aug 13, 2026

luacmartins changed the title ~~fix: use Neue font for donut chart center total to avoid missing glyph~~ fix: chart glyph fallback for currency symbols missing from the display font Aug 13, 2026

luacmartins added 8 commits August 13, 2026 15:35

update comments

0879ad2

test: use singleFontFamily constants instead of font-name string lite…

4c461ba

…rals

refactor: move glyph-fallback key mapping into chartTypefaceFallbacks…

ff22f87

… table

docs: simplify glyph-fallback table comment

884417d

test: import font families via FontUtils, drop eslint-disable

ceacc47

update comment

684f0d7

Merge branch 'main' into cmartins-fixDonutChartCurrencyTofu

c0618ff

# Conflicts: # tests/unit/getChartSkiaTypefaceTest.ts

rm mobe

38d0dbf

luacmartins marked this pull request as ready for review August 13, 2026 21:59

luacmartins requested review from a team as code owners August 13, 2026 21:59

melvin-bot Bot requested review from Ollyws and garrettmknight and removed request for a team August 13, 2026 21:59

luacmartins requested review from a team and removed request for Ollyws and garrettmknight August 13, 2026 21:59

melvin-bot Bot removed the request for review from garrettmknight August 13, 2026 21:59

melvin-bot Bot requested review from a team, Ollyws, garrettmknight and sobitneupane and removed request for a team August 13, 2026 21:59

luacmartins requested a review from a team August 13, 2026 21:59

github-actions Bot reviewed Aug 13, 2026

View reviewed changes

Comment thread src/components/Charts/utils/getChartSkiaTypeface.ts Outdated

garrettmknight previously approved these changes Aug 14, 2026

View reviewed changes

luacmartins dismissed garrettmknight’s stale review via b4617bd August 14, 2026 15:38

luacmartins added 2 commits August 14, 2026 09:40

update comment

f1c7ca7

Merge branch 'main' into cmartins-fixDonutChartCurrencyTofu

ce97b53

Ollyws approved these changes Aug 19, 2026

View reviewed changes

melvin-bot Bot requested a review from NicolasBonet August 19, 2026 13:49

NicolasBonet approved these changes Aug 19, 2026

View reviewed changes

NicolasBonet merged commit ab8ebaa into main Aug 19, 2026
44 of 46 checks passed

NicolasBonet deleted the cmartins-fixDonutChartCurrencyTofu branch August 19, 2026 14:30

OSBotify mentioned this pull request Aug 20, 2026

Deploy Checklist: New Expensify 2026-08-20 #99018

Closed

61 tasks

applause-bot Bot mentioned this pull request Aug 20, 2026

Concierge does not respond when ask: expenses broken down by category in offline mode #99060

Closed

7 tasks

melvin-bot Bot mentioned this pull request Aug 21, 2026

[Due for payment 2026-08-28] [Exploratory] Concierge - Currency symbol doesn't render correctly in Donut Chart #97341

Open

7 tasks

Uh oh!

Conversation

luacmartins commented Aug 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Aug 13, 2026

Uh oh!

Uh oh!

codecov Bot commented Aug 13, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

shawnborton commented Aug 14, 2026

Uh oh!

garrettmknight left a comment

Choose a reason for hiding this comment

Uh oh!

Ollyws commented Aug 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

luacmartins commented Aug 18, 2026

Uh oh!

Ollyws commented Aug 18, 2026

Uh oh!

Ollyws left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Aug 19, 2026

Uh oh!

NicolasBonet commented Aug 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Uh oh!

Uh oh!

OSBotify commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

github-actions Bot commented Aug 19, 2026

Uh oh!

OSBotify commented Aug 20, 2026

Uh oh!

MelvinBot commented Aug 20, 2026

Uh oh!

jponikarchuk commented Aug 20, 2026

Uh oh!

luacmartins commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Aug 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

luacmartins commented Aug 13, 2026 •

edited

Loading

codecov Bot commented Aug 13, 2026 •

edited by github-actions Bot

Loading

Ollyws commented Aug 18, 2026 •

edited

Loading

NicolasBonet commented Aug 19, 2026 •

edited

Loading

luacmartins commented Aug 20, 2026 •

edited

Loading