Skip to content

Fix pinned reports showing GBR dot instead of Pay/Approve badge in LHN #98840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
youssef-lr wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix pinned reports showing GBR dot instead of Pay/Approve badge in LHN #98840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/libs/actions/IOU/ReportWorkflow.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,6 +428,17 @@ function getIOUReportActionWithBadge(
}
}

// A chat's hasOutstandingChildRequest flag can flip true before its REPORT_ACTIONS are hydrated locally
// (e.g. pinning a previously-hidden chat pulls it into the LHN ahead of OpenReport, see
// https://github.com/Expensify/Expensify/issues/670825). When that happens the loop above finds no
// REPORT_PREVIEW action to badge, so fall back to the chat's iouReportID directly.
if (!actionBadge && chatReport?.hasOutstandingChildRequest && chatReport?.iouReportID) {
const iouReport = getReportOrDraftReport(chatReport.iouReportID, undefined, undefined, undefined, allReports?.[`${ONYXKEYS.COLLECTION.REPORT}${chatReport.iouReportID}`]);
if (iouReport && !isReportPendingDelete(iouReport)) {
actionBadge = getBadgeFromIOUReport(iouReport, chatReport, policy, reportMetadata, invoiceReceiverPolicy, currentUserLogin, currentUserAccountID);
}
}

return {reportAction: earliestAction, actionBadge};
}

Expand Down
Loading