Skip to content

fix(telemetry): drop untraceable Cannot call a class as a function noise from Sentry - #98866

Draft
WojtekBoman wants to merge 2 commits into
Expensify:mainfrom
software-mansion-labs:class-call-check-noise-filter
Draft

fix(telemetry): drop untraceable Cannot call a class as a function noise from Sentry#98866
WojtekBoman wants to merge 2 commits into
Expensify:mainfrom
software-mansion-labs:class-call-check-noise-filter

Conversation

@WojtekBoman

@WojtekBoman WojtekBoman commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This adds a web-only classCallCheckNoiseFilterIntegration that drops the untraceable TypeError: Cannot call a class as a function noise (APP-CN8 and siblings) coming from injected third-party scripts. It only discards an event when all three conditions hold: the message matches Babel's _classCallCheck signature, every stack frame is anonymous, and the event is already tagged third_party_code. The integration must run after thirdPartyErrorFilterIntegration, since it reads the tag that one sets - that ordering is pinned in setupSentry and covered by a dedicated unit test.

Fixed Issues

$ #93837
PROPOSAL:

Tests

  1. Run npx jest tests/unit/classCallCheckNoiseFilterTest.ts tests/unit/setupSentryIntegrationOrderTest.ts and verify both suites pass (predicate cases + integration order).
  2. Start the web app (npm run web), open the app in Chrome, enable the Sentry debug toggles in the dev tools menu ("Send data to Sentry" off, "Log Sentry to console" on), then in the browser console run:
    Sentry.captureEvent({
        tags: {third_party_code: true},
        exception: {values: [{type: 'TypeError', value: 'Cannot call a class as a function', stacktrace: {frames: [{filename: 'app:///'}]}}]},
    });
    Verify no envelope for that event is logged to the console (the event was dropped).
  3. In the same console run the same snippet twice more, changing one condition each time:
    • filename: 'app:///76-abc123.bundle.js' (named frame)
    • tags: {} (no third_party_code tag)
      Verify each of those events IS logged as an outgoing envelope, i.e. only the all-anonymous third-party signature is dropped.
  4. Trigger a normal app error (e.g. throw new Error('sentry sanity check') in the console) and verify it is still logged as an outgoing envelope, confirming no regression in regular error reporting.
  5. On Android/iOS native, launch the app and verify it boots with no JS console errors - the filter is stubbed to undefined on native and must not appear in the integration list.

Offline tests

N/A - no API calls or Onyx operations; the change only filters events inside the Sentry SDK pipeline before transport.

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests (steps 1-4 are dev-only; on staging, verify the app loads on all platforms and that errors intentionally triggered in the app still appear in Sentry, while third_party_code:True Cannot call a class as a function events stop arriving for the staging release).

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@codecov

codecov Bot commented Aug 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...elemetry/integrations/classCallCheckNoiseFilter.ts 100.00% <100.00%> (ø)
src/libs/telemetry/integrations/index.ts 100.00% <100.00%> (ø)
src/libs/telemetry/integrations/index.web.ts 0.00% <ø> (ø)
src/setup/telemetry/setupSentry.ts 100.00% <100.00%> (+100.00%) ⬆️
... and 255 files with indirect coverage changes

@WojtekBoman
WojtekBoman force-pushed the class-call-check-noise-filter branch from 3789971 to fd637d6 Compare August 18, 2026 13:29
@WojtekBoman
WojtekBoman force-pushed the class-call-check-noise-filter branch from fd637d6 to 873e845 Compare August 18, 2026 13:41
@WojtekBoman

Copy link
Copy Markdown
Contributor Author

@codex

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: 873e845e6d

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant