Backport missing ViewState guards for state and padding updates - #98869
Open
KJ21-ENG wants to merge 1 commit into
Open
Backport missing ViewState guards for state and padding updates#98869KJ21-ENG wants to merge 1 commit into
KJ21-ENG wants to merge 1 commit into
Conversation
Contributor
|
|
KJ21-ENG
marked this pull request as ready for review
August 18, 2026 13:47
melvin-bot
Bot
requested review from
eVoloshchak
and removed request for
a team
August 18, 2026 13:48
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Extends the existing React Native 0.86 patch for missing Android Fabric
ViewStatevalues. The patch already guardsupdateOverflowInset; this follow-upbackports React Native commit
0e86a043soupdatePaddingandupdateStatealsouse
getNullableViewState(), soft-log a missing state, and return instead ofthrowing
RetryableMountingLayerExceptionfrom a non-retryableIntBufferBatchMountItem.This addresses the production
9.4.46-10fatal recurrence whose stack isgetViewState -> updateState -> IntBufferBatchMountItem. Search/FlashListclipping,
sendAccessibilityEvent, andsetJSResponderare intentionallyunchanged.
Fixed Issues
$ #93833
PROPOSAL: #93833 (comment)
Tests
The production crash is nondeterministic, so these steps provide regression
smoke coverage rather than deterministic proof of the fix.
Final effectiveness will be confirmed by monitoring APP-3E3 after deployment.
inside React Native and introduces no JS/TS execution path.
Offline tests
N/A. The guard runs in React Native's Android Fabric mounting layer and does not
depend on network, Onyx, account, or permission state.
QA Steps
Same as Tests. Treat this as regression smoke coverage only; monitor APP-3E3
after deployment to confirm effectiveness.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionViewStateis the failure path handled by the guard; there is no input or user-facing error state.ViewStateguard pattern.mainwas merged after review, I tested again. N/A: the branch starts from currentupstream/mainand no later merge has occurred.Screenshots/Videos
Android: Native
N/A: no visual change.
Android: mWeb Chrome
N/A: Android native-only change.
iOS: Native
N/A: Android native-only change.
iOS: mWeb Safari
N/A: Android native-only change.
MacOS: Chrome / Safari
N/A: Android native-only change.