Show thread title - #99317
Conversation
|
@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 130ca3b257
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
Explanation of Change
Chat thread names are derived from the parent message, so a Concierge thread ignored the title the backend now sets. This prefers a real stored
reportNamewhen the thread's parent is the Concierge DM, compared againstDEFAULT_REPORT_NAMEsince Auth persists the literal"Chat Report".Also drops the optimistic
reportName, which was HTML and would have rendered raw<strong>tags in the LHN. Needs https://github.com/Expensify/Web-Expensify/pull/55576 and https://github.com/Expensify/Auth/pull/23917.Fixed Issues
$
PROPOSAL:
Tests
conciergeRespondInThreadbeta and ask Concierge a multi-sentence question containing bold text or a link.Offline tests
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari