Skip to content

[No QA] Update Manage-Copilot-Access.md - #99487

Open
brianlee-expensify wants to merge 1 commit into
mainfrom
brianlee-expensify-patch-4
Open

[No QA] Update Manage-Copilot-Access.md#99487
brianlee-expensify wants to merge 1 commit into
mainfrom
brianlee-expensify-patch-4

Conversation

@brianlee-expensify

Copy link
Copy Markdown
Contributor

Explanation of Change

  • added bulletpoint about how Copilot can merge accounts on the signed in user's behalf.

Fixed Issues

https://github.com/Expensify/Expensify/issues/671341#issuecomment-5375220387

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

- Create and manage expenses on your behalf
- Review reports
- Access account, workspace, and domain settings based on their assigned permissions
- Merge accounts on your behalf (Full Access only). The security code is sent to you, the account owner. You will have to share the security code with the person who is the Copilot for your account, so please share it with caution.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Readability / structure: This bullet mixes a capability statement with multi-sentence security guidance, breaking the concise, scannable pattern of the surrounding list (per HELP_AUTHORING_GUIDELINES.md Sections 1 and 5, "concise and actionable"). Keep the list item short (e.g. - Merge accounts on your behalf (Full Access only)) and move the security-code explanation into a sentence or a dedicated task-based ## section / FAQ entry below the list.

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a single bullet point to docs/articles/new-expensify/settings/Manage-Copilot-Access.md, under the A Copilot can: list, documenting that a Full Access Copilot can merge accounts on the signed-in user's behalf, along with a security-code-sharing caveat. The addition covers a real user concern, but the phrasing breaks the parallel structure of the surrounding list and uses soft, wordy language that departs from the article's otherwise deterministic style.

Scores Summary

  • Readability: 6/10 - The new bullet packs three sentences (capability + security-code explanation + caution) into a single list item, while every other bullet in the list is a short action phrase. Wording like "the person who is the Copilot for your account" and "please share it with caution" is verbose and awkward.
  • AI Readiness: 7/10 - Uses existing feature vocabulary (Copilot, Full Access) and slots into an established task-based section, so retrieval structure is preserved. However, "Merge accounts" should be verified as the exact UI label, and the embedded security-code caveat is really a sub-topic better handled as its own sentence or an FAQ entry than buried in a capabilities bullet.
  • Style Compliance: 7/10 - "Full Access" correctly matches the capitalized access level used elsewhere. But "so please share it with caution" is soft, non-deterministic phrasing that the Deterministic Writing Rule discourages, and the multi-sentence bullet breaks parallelism with the concise action phrases in the rest of the list.

Key Findings

  • The bullet mixes two ideas - a capability ("Merge accounts on your behalf") and a security warning - inside one list item, breaking the clean parallel structure of the "A Copilot can:" list.
  • Wordiness: "the person who is the Copilot for your account" can simply be "your Copilot"; "so please share it with caution" is vague and soft.
  • Positive: correctly scopes the capability with "(Full Access only)" and reuses existing terminology, so it fits the article's model of access levels.
  • Verify "Merge accounts" matches the exact in-product UI label per the Core UI Referencing Rules.

Recommendations

  • Keep the capabilities bullet short and parallel, e.g. - Merge accounts on your behalf (Full Access only), and move the security-code guidance into a dedicated sentence or an FAQ entry (e.g. "What happens when a Copilot merges accounts on my behalf?").
  • Tighten the caveat: "The account merge security code is sent to you as the account owner. You must share it with your Copilot to complete the merge, so treat it as sensitive." Avoid "please" and "with caution."
  • Confirm the "Merge accounts" wording matches the exact UI label; adjust to match the product if it differs.

Files Reviewed

  • docs/articles/new-expensify/settings/Manage-Copilot-Access.md - One bullet added; accurate and correctly scoped, but wordy and non-parallel with the surrounding list.

Note: Detailed line-by-line feedback has been provided as inline comments.

@github-actions github-actions Bot changed the title Update Manage-Copilot-Access.md [No QA] Update Manage-Copilot-Access.md Aug 25, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://b36f8671.helpdot.pages.dev ⚡️

Updated articles:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants