[No QA] Split app TypeScript into web and native programs - #99495
Draft
roryabraham wants to merge 3 commits into
Draft
[No QA] Split app TypeScript into web and native programs#99495roryabraham wants to merge 3 commits into
roryabraham wants to merge 3 commits into
Conversation
Phase 2 of the tsconfig cleanup: typecheck src as separate web (DOM + .web suffixes) and native (no DOM + ios/android/native suffixes) projects instead of one mega-program. Move Window/Document/env ambients off the native graph, point ESLint src/** at the web project, and restrict Jest globals in app code.
|
Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers! |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Drop unused type re-exports from platform index files, restore the native PopoverProvider no-arg stubs the compiler already accepted, and rephrase the evals README so cspell does not flag typechecks.
Native typecheck still includes unsuffixed Popover callers that pass an argument to close/onOpen. Optional params on the type keep those calls valid; implementations stay no-arg so the React Compiler and eslint unused-vars stay clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Phase 2 of the tsconfig cleanup: typecheck the app as separate web and native programs instead of one mega-program.
tsconfig.app.web.json(moduleSuffixes: [".web", ""], DOM, RN-web) andtsconfig.app.native.json(moduleSuffixes: [".ios", ".android", ".native", ""], no DOM).npm run typecheckat web + native + jest/root + bun + node + VCR. Roottsconfig.jsonno longer includessrcas a mega-program.src/types/web,src/types/app,types/env.d.ts).NodeRequireon both app programs. ESLintsrc/**uses the web project; native-suffixed files use the native project.no-restricted-globalsbansjest/describe/it/test/expectinsrc/**.Fixed Issues
$ #99287
Tests
CI only.
npm run typecheckand verify it checkstsconfig.app.web.json,tsconfig.app.native.json,tsconfig.json,tsconfig.bun.json,tsconfig.node.json, and VCR.document/windowuse in a.native.tsfile is a type error undertsconfig.app.native.json.src/**ESLint uses the web project and reportsjest/describe/it/expectas restricted globals.Offline tests
n/a
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionScreenshots/Videos
Not applicable: tooling-only change.