Skip to content

hotfix: infinite render of ethereum phantom wallet pop up #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kabugatti wants to merge 4 commits into
base: app-main
Choose a base branch
from
Open

hotfix: infinite render of ethereum phantom wallet pop up #250

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78c5038
feat: create helper for message signing
kabugatti Aug 25, 2025
2419c3d
fix: coderabbit suggestions
kabugatti Aug 26, 2025
39e0278
Merge branch 'Explore-Beyond-Innovations:app-main' into app-main
kabugatti Sep 10, 2025
eaeff7d
hotfix: fix infinite auth model pop up rendering
kabugatti Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/hooks/useWallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ export const useWallet = () => {
ethWallet.isConnected,
ethWallet.isConnecting,
ethWallet.chainId,
setEthWallet,
]);

// Separate effect for authentication that runs when Ethereum address changes
Expand Down Expand Up @@ -148,7 +147,7 @@ export const useWallet = () => {
connected: strkWallet.status === "connected",
connecting: strkWallet.status === "connecting",
});
}, [strkWallet.account?.address, strkWallet.status, setStrkWallet]);
}, [strkWallet.account?.address, strkWallet.status]);

// Separate effect for Starknet authentication that runs when Starknet address changes
useEffect(() => {
Expand Down