Skip to content

Conversation

@Zeno410
Copy link

@Zeno410 Zeno410 commented Aug 31, 2013

Adding in Constructs code. Works to a quick test, although I had to modify CommandOreDictify on the local version as it made an obfuscated call my library did not recognize.

Zeno410 and others added 4 commits August 31, 2013 14:50
Switching files from master to 1.6.1
Modifying UndergroundBiomes.java to make calls to
UndergroundBiomesConstructs
@grompe
Copy link
Collaborator

grompe commented Sep 1, 2013

Alright, I did some testing:

  • Recipes should be adjusted to match original, UB ones changed if needed
  • Not all items should be craftable: no smoothstone stairs, no brick buttons
  • In creative picking blocks picks wrong one
  • Metamorphic stone walls have incorrect localization
  • It is impossible to put torches on top of walls
  • Sometimes wall item on the ground from a broken wall graphically shows as a different one (?)
  • Internal: no need to traverse through blocks to find UB blocks, change UB code if needed

@Zeno410
Copy link
Author

Zeno410 commented Sep 3, 2013

OK, added config controls. All fixes done except:

Smoothstone stairs: that was the #1 reason I did this mod. I'm not changing it.

Creative mode: I deliberately didn't add the constructs to the creative tabs (because, 168 blocks, OK now 152 without brick buttons but still way too many). I can't find them on the creative tabs, which is what I expect. I tried making constructs from the three different stone groups using a crafting table and they all worked.

Button recipes: I thought you said somewhere in the UB thread that you didn't like one-stone recipes. That's part of why it was 2-stone in the first place.

Finally, the fix to allow standard recipes didn't require (easy) changes to UB recipes, but considerably hairier changes to OreDictify. The fix I used is to suppress all changes to whatever construct types are active. This will work with vanilla but will not allow UB blocks to be used to make constructs via other recipes. That seems unlikely to be a problem, but I suppose it could. The more precise fix would be to suppress OreDictify changes that overwrite UB recipes but that would be substantially harder to program.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants