Skip to content

Python 3.8 - Update _check_keys to avoid Runtime Error when sanitizing response for keywords #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Python 3.8 - Update _check_keys to avoid Runtime Error when sanitizing response for keywords #1562

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions f5/bigip/resource.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,18 +488,20 @@ def _check_keys(self, rdict):
error_message = "Response contains key '_meta_data' which is "\
"incompatible with this API!!\n Response json: %r" % rdict
raise DeviceProvidesIncompatibleKey(error_message)
for x in rdict:
if not re.match(tokenize.Name, x):

copy_rdict = copy.deepcopy(rdict)
for key, value in iteritems(copy_rdict):
if not re.match(tokenize.Name, key):
error_message = "Device provided %r which is disallowed"\
" because it's not a valid Python 2.7 identifier." % x
" because it's not a valid Python 2.7 identifier." % key
raise DeviceProvidesIncompatibleKey(error_message)
elif keyword.iskeyword(x):
elif keyword.iskeyword(key):
# If attribute is keyword, append underscore to attribute name
rdict[x + '_'] = rdict[x]
rdict.pop(x)
elif x.startswith('__'):
rdict[key + '_'] = value
rdict.pop(key)
elif key.startswith('__'):
error_message = "Device provided %r which is disallowed"\
", it mangles into a Python non-public attribute." % x
", it mangles into a Python non-public attribute." % key
raise DeviceProvidesIncompatibleKey(error_message)
return rdict

Expand Down