Fix Python SyntaxWarnings in iapp_parser.py #1612
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I run Python's `compileall` code of the `f5-sdk` Python package, I get the following SyntaxWarnings: ``` % python3 -m compileall iapp_parser.py Compiling 'iapp_parser.py'... iapp_parser.py:123: SyntaxWarning: "is" with a literal. Did you mean "=="? if brace_count is 0: iapp_parser.py:126: SyntaxWarning: "is not" with a literal. Did you mean "!="? if brace_count is not 0: ``` This PR fixes these warnings. Using Python 3.11.2, but I believe these warnings were already introduced in Python 3.8. Background: https://adamj.eu/tech/2020/01/21/why-does-python-3-8-syntaxwarning-for-is-literal/
Author
|
Solves part of #1554. @zhaoqin-github Ping? |
Contributor
Hi Marti, As described in the README at main page, this python module is "NO LONGER UNDER ACTIVE DEVELOPMENT". I am not the maintainer of this project, and will not publish a new version for public usage. If you need this change, maybe you can manage it in your downstream repo and create package by yourself. Very sorry for that! |
Author
|
Hi. Fair enough. I interpreted "not under active development" as in "we are no longer adding new features". If you mean that this project is unmaintained -- bugs won't be fixed etc -- then I think the message could be clearer. Say it in the heading that this is unmaintained, and "issues and pull requests will not be handled". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I run Python's
compileallon code of thef5-sdkPython package, I get the following SyntaxWarnings:This PR fixes these warnings.
Using Python 3.11.2, but I believe these warnings were already introduced in Python 3.8.
Background: https://adamj.eu/tech/2020/01/21/why-does-python-3-8-syntaxwarning-for-is-literal/