Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

print more specific error on scontrol fail; return cluster unknown #1039

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

print more specific error on scontrol fail; return cluster unknown #1039

wants to merge 2 commits into from

Conversation

misko
Copy link
Collaborator

@misko misko commented Feb 27, 2025

No description provided.

@misko misko added enhancement New feature or request patch Patch version release labels Feb 28, 2025
@misko misko marked this pull request as ready for review February 28, 2025 00:21
@codecov Codecov
Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/fairchem/core/common/utils.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
src/fairchem/core/common/utils.py 67.36% <0.00%> (ø)

rayg1234
rayg1234 reviewed Feb 28, 2025
View reviewed changes
src/fairchem/core/common/utils.py
return None
logging.warning(
f"scontrol command failed, couldn't find cluster name, returning UNKOWN as cluster name {e!s}"
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change also function signature to only return str

rayg1234
rayg1234 approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@rayg1234 rayg1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@misko misko added this pull request to the merge queue Feb 28, 2025
@misko misko removed this pull request from the merge queue due to a manual request Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayg1234 rayg1234 rayg1234 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request patch Patch version release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@misko @rayg1234