Create skeleton of new libraries with samples#1
Merged
jennyhougen merged 30 commits intomainfrom May 8, 2025
Merged
Conversation
Adding authorization logic
ghost
reviewed
May 5, 2025
bvst
reviewed
May 6, 2025
bvst
reviewed
May 6, 2025
GeirMG
approved these changes
May 6, 2025
Contributor
GeirMG
left a comment
GeirMG
left a comment
There was a problem hiding this comment.
Nice work! I have some minor suggestions:
The solution file is misspelled:
Fhi.AuthExtenions.sln -> Fhi.AuthExtensions.sln
Also applies to: Fhi.AuthExtenions.slnLaunch
Is it a good idea to create a constant class for constants not found in: OpenIdConnectParameterNames?
public static class AuthConstants
{
public const string Sub = "sub";
public const string ExpiresAt= "expires_at";
Etc...
}
Add indent rule for .csproj files in .editorconfig :)
bvst
reviewed
May 6, 2025
bvst
reviewed
May 6, 2025
bvst
reviewed
May 6, 2025
bvst
reviewed
May 6, 2025
bvst
reviewed
May 6, 2025
Co-authored-by: Geir Marius <gmgjul@gmail.com>
Co-authored-by: Geir Marius <gmgjul@gmail.com>
Co-authored-by: Geir Marius <gmgjul@gmail.com>
Co-authored-by: Geir Marius <gmgjul@gmail.com>
Co-authored-by: Geir Marius <gmgjul@gmail.com>
GeirMG
reviewed
May 7, 2025
Co-authored-by: Geir Marius <gmgjul@gmail.com>
Co-authored-by: Geir Marius <gmgjul@gmail.com>
…lBearerTokenWorker.cs Co-authored-by: Geir Marius <gmgjul@gmail.com>
…lBearerTokenWorker.cs Co-authored-by: Geir Marius <gmgjul@gmail.com>
…andler.cs Co-authored-by: Geir Marius <gmgjul@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.