-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Jitify2 #1150
base: master
Are you sure you want to change the base?
Migrate to Jitify2 #1150
Conversation
if [[ ${package} == *devel* ]] && version_lt "$CUDA_VERSION_MAJOR_MINOR" "11.0" ; then | ||
package="${package//devel/dev}" | ||
# libnvjitlink not required prior to CUDA 12.0 | ||
if [[ ${package} == libnvjitlink-dev* ]] && version_lt "$CUDA_VERSION_MAJOR_MINOR" "12.0" ;then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is as narrow as it could be, but I wanted to make minimal changes to get it working.
The wildcard on libnvjitlink-dev
can probably be removed.
Same issue in the ubuntu script
Update regarding header pre-loading with Jitify2/CUDA 12.3 Windows/CUDA 12.0
Linux/CUDA 12.3
CUDA 12.0 has ~30 CUDA headers to preload. Not clear whether we would want to generalise this code, to better handle different CUDA versions, because we could be potentially needing to update it with each CUDA update. Edit: Removed from-cache times, latest commit has these matching Jitify1. |
Slow (as we haven't got our pre-header hack) and lacks serialization.
…ed (cuda11 may still be dead)
Triggering compile of the preprocessed source after deserialisation is still fast.
This only reduces time from 6.8s to 4.1s (Windows/CUDA 12.0) and can't easily extend it to system headers.
Quick windows test shows it to be much faster to deserialize.
…cking doesnt work in docker
Current issue holding back the Jitify2 preprocesor branch is that it expects our flamegpu headers to be included as system header |
Same fix earlier applied to agent functions.
Negligible impact with preprocess branch also lint fixes that should have been commit earlier.
Did three full test runs last night, all passed, however in those cases the cmake jitify dependency was pointing at the preprocess branch. Not currently using that here as it causes all windows CI to fail with WError. Linux/CUDA12.3/Seatbelts ON/GLM ON/Release In release builds kernels are taking ~1 second to compile each. As Jitify is now doing the pre-processing, this is closer to 2.5 seconds under Debug builds. |
The updated jitify2 branch uses c++ features which error on windows with CUDA 11.0 and 11.1, but 11.2+ is fine. This was a planned change anyway for CCCL support (see #1155), so will just need dealing with here too/instead. Another option (to discuss) would be to drop 11.x more widely (although I'd rather not yet) as the plan is to only support 2 major cuda versions and I expect 13 to turn up this year, but would rather not do that yet. For wheel production on github actions, we do need to maintain vs 2019 support, with the recent change for vs2022 updates requireing 12.4, even if we drop cuda 11.0. |
launch()
method (used inCUDASimulation
), says to replace withlaunch_raw()
.cuda().ModuleUnload()
during sim shutdown, whenCUDAAgent
map is cleared byCUDASimulation
destructor.jitify2-misc-fixes2
branch)curve_rtc.cpp