don't run GetCaseName with Path.Combine on rooted path #489
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a copy-pasto from the lines just below that use the same structure
if(Path.IsPathRooted...){...}...;
, but there it's fine because those arereturn statements
. Here the result for a rooted path would be addition ofTitleLocation.Path
before the already rooted path.From my observation with some debug prints, I don't think rooted paths are encountered much (if ever). This is likely the reason why this issue hasn't shown up.