Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't run GetCaseName with Path.Combine on rooted path #489

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

rfht
Copy link
Contributor

@rfht rfht commented Jul 1, 2024

This looks like a copy-pasto from the lines just below that use the same structure if(Path.IsPathRooted...){...}...;, but there it's fine because those are return statements. Here the result for a rooted path would be addition of TitleLocation.Path before the already rooted path.

From my observation with some debug prints, I don't think rooted paths are encountered much (if ever). This is likely the reason why this issue hasn't shown up.

@flibitijibibo flibitijibibo merged commit 31dab88 into FNA-XNA:master Jul 2, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants