Skip to content

changes to histogram function #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MustaphaBraimoh wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

changes to histogram function #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e9c9e3
changes to histogram function
Nov 14, 2024
b38abe2
Merge branch 'dev' into histogram_updates2
ThomasSheeley Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/spac/visualization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,10 @@ def tsne_plot(adata, color_column=None, ax=None, **kwargs):

return fig, ax

def cal_bin_num(num_rows):
bins = max(int(2 * (num_rows ** (1/3))), 1)
print(f'Automatically calculated number of bins is: {bins}')
return bins

def histogram(adata, feature=None, annotation=None, layer=None,
group_by=None, together=False, ax=None,
Expand Down Expand Up @@ -530,10 +534,16 @@ def histogram(adata, feature=None, annotation=None, layer=None,

axs = []

# Determine bins if not provided
if 'bins' not in kwargs:
num_rows = len(df)
kwargs['bins'] = cal_bin_num(num_rows)

# Prepare the data for plotting
plot_data = df.dropna(subset=[data_column])

# Plotting with or without grouping

if group_by:
groups = df[group_by].dropna().unique().tolist()
n_groups = len(groups)
Expand Down
Loading