feat: Add configurable ports with environment variables #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add port configuration via environment variables (TRINO_PORT, SHINY_PORT, SPARK_PORT, POSTGRES_PORT, HIVE_PORT) - Change default Trino port from 8081 to 8083 to avoid common conflicts - Update docker-compose.yml to use environment variables with fallback defaults - Update Makefile with port configuration examples and dynamic port display - Update README.md with comprehensive port configuration documentation - Add remote access instructions for SSH and VS Code port forwarding This allows users to easily customize ports to avoid conflicts with existing services.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to easily customize ports to avoid conflicts with existing services.