Skip to content

Restructured the directories and files #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

rachit-goyal1071
Copy link
Contributor

@rachit-goyal1071 rachit-goyal1071 commented May 19, 2024

Fixes

Related to #16 by @Utkarsh4517

Description

Folders have been restructured as mentioned, bloc architecture has not yet been started will work on it soon.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

@Utkarsh4517 Utkarsh4517 self-requested a review May 19, 2024 17:42
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep the auth_service in lib/src/auth/data.
Only keep those services in core which are used by more than one feature.

@Utkarsh4517
Copy link
Member

While I appreciate your time and effort, but this is an incomplete PR related to issue #16. Feel free to ask your doubts at #16. 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants