Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom player sprays stopped working after player respawning #514

Closed
SNMetamorph opened this issue Mar 2, 2025 · 6 comments
Closed

Custom player sprays stopped working after player respawning #514

SNMetamorph opened this issue Mar 2, 2025 · 6 comments

Comments

@SNMetamorph
Copy link
Member

SNMetamorph commented Mar 2, 2025

After joining on the server and making spray, everything works, but after death and respawning, only placeholder spray was printed, instead of player custom spray.

FWGS/xash3d-fwgs#2059

@FreeSlave
Copy link
Member

Could be related to 1a4d59f ?

@SNMetamorph
Copy link
Member Author

Yeah, could be. But is CBasePlayer::Precache should be called after death/spawn? I'm not sure it should, so this maybe not the reason.

@nekonomicon
Copy link
Member

Yep.

@FreeSlave
Copy link
Member

respawn calls CBasePlayer::Spawn and it calls CBasePlayer::Precache.
Maybe move the change from the commit to the CBasePlayer::Restore?

@a1batross
Copy link
Member

That sounds like a better fix to me.

@SNMetamorph
Copy link
Member Author

Maybe move the change from the commit to the CBasePlayer::Restore?

Agree. My first thought yesterday was "why isn't it in Restore instead of Precache", so then I know that this was the reason :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants