Fix webhook signature verification raw body handling#216
Open
sravan27 wants to merge 2 commits into
Open
Conversation
- app.module.ts: remove duplicate AdminModule/TreasuryModule/DevModule imports, add missing CorrelationMiddleware import - webhooks.service.ts: collapse three interleaved duplicate implementations (dispatchEvent, emitKycEvent, verifyWithRotation, rotateSecret) into single clean versions; remove duplicate events key in createWebhookSchema - webhook-delivery.worker.ts: merge two interleaved deliver() bodies into one; fix double catch block - invoices.service.ts: remove duplicate const result in expireInvoices() - audit/audit.service.ts: add webhook_replayed to AuditAction type - treasury/dto: add definite assignment assertion to signingQuorum - test fixes: deduplicate mockAudit, add missing AppLogger mock arg, fix ConfigService cast, fix supertest import style - tsconfig.json: correct ignoreDeprecations from "6.0" to "5.0" - package.json: add supertest + @types/supertest@6 devDependencies Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19.
Summary
string | BufferbodiesValidation
npm test -- --runTestsByPath src/webhooks/webhooks-signature.spec.ts src/webhooks/webhooks-deliveries.spec.ts --runInBandnpm run typechecknpm run buildgit diff --checkNote: local
npm run lint -- --quiet src/webhooks/webhooks.service.ts src/webhooks/webhooks-signature.spec.tsis blocked because this lockfile install does not provide aneslintbinary (sh: eslint: command not found).