Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic logger interface #138

Merged
merged 5 commits into from
Nov 8, 2024
Merged

Add a basic logger interface #138

merged 5 commits into from
Nov 8, 2024

Conversation

modmuss50
Copy link
Member

First stage of improving the log messages.

Has a slight breaking change to anyone who was passing a custom logger to the mixin extension.

@modmuss50 modmuss50 requested a review from sfPlayer1 October 15, 2024 20:44
Copy link
Collaborator

@sfPlayer1 sfPlayer1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential additions might be categories and context objects (like affected ClassInstance etc) but this should be fine for now.

@modmuss50
Copy link
Member Author

Potential additions might be categories and context objects (like affected ClassInstance etc) but this should be fine for now.

Yes, being able to specify class/method context is the next thing I want to do. It will be especially useful for the mixin remapping.

@modmuss50 modmuss50 merged commit fccc068 into FabricMC:master Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants