Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/mixin improvements #144

Merged
merged 2 commits into from
Jan 20, 2025

Conversation

LlamaLad7
Copy link
Contributor

@LlamaLad7 LlamaLad7 commented Jan 20, 2025

The first commit is to ignore Mixin remap values and just soft-fail if the name isn't remappable, like everywhere else. This is desirable for the user and simplifies the code quite a lot.
I tested this on the latest fabric-api and it produces a jar which is identical to that with tiny-remapper#master, as judged by running jardiff on all the nested jars.

However, the produced jar crashes due to some remapped accessor methods, hence my second commit. It is deeply undesirable to change the actual name of user-defined Accessors and Invokers, so instead if the name is meant to be inferred, we add the remapped name to the annotation.

This is enough to build a fully working FAPI. Commits should be reviewed individually and not squashed.

@LlamaLad7 LlamaLad7 force-pushed the feature/mixin-improvements branch from c6f4c50 to 4276f92 Compare January 20, 2025 10:00
Copy link
Member

@modmuss50 modmuss50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner, thanks for this 👍

@modmuss50 modmuss50 merged commit 64e7855 into FabricMC:master Jan 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants