-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map the RedstoneConstants class #2961
base: 1.19.3
Are you sure you want to change the base?
Conversation
again, why wouldn't this be light constants (min level, max level, default block level) or chunk (size, offset, etc) constants? |
@@ -1,7 +0,0 @@ | |||
CLASS net/minecraft/class_6148 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should just be moved into the existing unused package next to where all of the package info's live.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the class keep these new mappings as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unless there is definitive proof that these are and only are constants for redstone values (also two of the fields have same value, dunno how you can tell them apart), they should not keep the mappings and the class name you give it.
Maybe something like the original https://github.com/liach/yarn/blob/83ec0c0aff1f3a94693e4333eb4ba04e6e490878/mappings/net/minecraft/unused/UnknownWorldConstants6148.mapping
🚀 Target branch has been updated to 1.18.2 |
I don't have an issue with this myself, it seems fairly logical and changing this stuff in the future will only break source compatibility due to constant inlining. |
This is likely to be a class holding redstone constants for the following reasons:
LightingProvider#field_31713
field already contains a max light constant