Conversation
Allow setting the VPA containerPolicies controlledValues (RequestsAndLimits or RequestsOnly) with a simple label or annotation on a namespace or workload, similar to vpa-update-mode, instead of having to write the vpa-resource-policy JSON. The value is applied to all containers and merged with any vpa-resource-policy; explicit values there win.
yeniklas
requested review from
Azahorscak,
sudermanjr and
transient1
as code owners
September 24, 2026 12:20
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow setting the VPA containerPolicies controlledValues (RequestsAndLimits or RequestsOnly) with a simple label or annotation on a namespace or workload, similar to vpa-update-mode, instead of having to write the vpa-resource-policy JSON. The value is applied to all containers and merged with any vpa-resource-policy; explicit values there win.
This PR addresses the issue: #890
Description
What's the goal of this PR?
To provide a user friendly way to change "controlledValues". Our developers would feel more confident to use a clear single purpose label, than to put the whole json template in their charts. This change would provide that.
What changes did you make?
I've added a label to adjust controlledValues, the same way as updateMode.
What alternative solution should we consider, if any?
Another alternative would be to make the resource-policy a central configuration. That might be closer to what the issue refers to. But the new label feels more coherent with the existing behavior. I think both ways could work, and the two variations don't need to be mutually exclusive.
Feel free to tell me if I missed anything.
I ran the tests, including the e2e-tests in Kind.
Full transparency, this change was made with assistance of an AI agent.
Best regards!