Add first-letter as a pseudo element and update factory to support it #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisbader
suggested changes
Oct 17, 2025
travisbader
left a comment
travisbader
left a comment
There was a problem hiding this comment.
Have you tested this produces the expected results in Vyrso yet? I would like to see that done and up for PR before approving this.
You can do so by moving your locally compiled Anglesharp.Css dll here
lorenzolliteras
force-pushed
the
CPT-7679
branch
from
f73939f to
f16fdb8
Compare
Author
|
I did test VyrsoTools with a test i created, ill link the PR for VyrsoTools adding that test |
travisbader
reviewed
Oct 17, 2025
lorenzolliteras
force-pushed
the
CPT-7679
branch
from
17d4fde to
ace15c6
Compare
lorenzolliteras
commented
Oct 20, 2025
travisbader
suggested changes
Oct 20, 2025
src/AngleSharp.Css.Tests/Styling/FirstLetterPseudoElementTests.cs
Outdated
Show resolved
Hide resolved
lorenzolliteras
force-pushed
the
CPT-7679
branch
2 times, most recently
from
2c807f5 to
3dcd878
Compare
travisbader
reviewed
Oct 20, 2025
lorenzolliteras
force-pushed
the
CPT-7679
branch
from
3dcd878 to
56ceee6
Compare
lorenzolliteras
force-pushed
the
CPT-7679
branch
from
56ceee6 to
8ee7106
Compare
travisbader
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CPT-7679
Link to VyrsoTools test PR