Check archive block height before sending subscribers notification#403
Merged
Check archive block height before sending subscribers notification#403
Conversation
HerbertJordan
approved these changes
Apr 8, 2025
thaarok
reviewed
Apr 10, 2025
jenikd
commented
Apr 10, 2025
Collaborator
Author
jenikd
left a comment
jenikd
left a comment
There was a problem hiding this comment.
Thanks for feedback
thaarok
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves issue, when there is a asynchronous write to the archive state database. This approach was added not to block block processing with write to archive as this is expensive operation.
In some cases update was done only to live database and RPC subscribers were notified about new block, but it was not yet written to archive.