Skip to content

[OZ][L-02] Transfer and send Calls Are No Longer Considered Best Practice#111

Merged
Mike-CZ merged 3 commits intomainfrom
mike/oz-l-02
Jan 31, 2025
Merged

[OZ][L-02] Transfer and send Calls Are No Longer Considered Best Practice#111
Mike-CZ merged 3 commits intomainfrom
mike/oz-l-02

Conversation

@Mike-CZ
Copy link
Collaborator

@Mike-CZ Mike-CZ commented Dec 13, 2024

This PR replaces transfer call with call as it is not considered best practise.

@Mike-CZ Mike-CZ requested a review from thaarok December 13, 2024 09:17
thaarok
thaarok previously approved these changes Dec 16, 2024
Copy link
Collaborator

@thaarok thaarok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok.
ReentrancyGuard was suggested too, but it should not be necessary as this external call follows after all state changes.

@Mike-CZ Mike-CZ merged commit 86add7e into main Jan 31, 2025
2 checks passed
@Mike-CZ Mike-CZ deleted the mike/oz-l-02 branch January 31, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants