Add a 'partial' model type#115
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #115 +/- ##
=======================================
Coverage ? 96.73%
=======================================
Files ? 9
Lines ? 460
Branches ? 47
=======================================
Hits ? 445
Misses ? 7
Partials ? 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
martinjrobins
left a comment
There was a problem hiding this comment.
code looks good to me, thanks @pipliggins. I'll let @rtimms check the match with the published schema
There was a problem hiding this comment.
thanks @pipliggins LGTM! Could you update the changelog, please?
Done @rtimms - If a partial schema is defined, should the |
d72e2ad to
09646ce
Compare
The 'State' section introduced by #113 is now optional for partial models, with a custom check to ensure it's present for anything other than |
|
@pipliggins great, thanks! |
Fixes #40
Adds 'Partial' as a model option, which rules that all the top-level parameters (cell, electrodes, separator, electrolyte, user-defined) are optional, along with the 'State' section. Any parameter group (e.g.
Cell) provided must be complete.Checks that: