Add-custom-module-functions-functionality#70
Draft
mleot wants to merge 15 commits intoFaradayInstitution:developfrom
Draft
Add-custom-module-functions-functionality#70mleot wants to merge 15 commits intoFaradayInstitution:developfrom
mleot wants to merge 15 commits intoFaradayInstitution:developfrom
Conversation
Merge develop into main for v0.4.0 release
* Revamp publishing workflow * Add condition for PyPI push * attestations are now enabled by default Co-authored-by: Saransh Chopra <saransh0701@gmail.com> * Inspect sdist + wheel, pin actions to hashes --------- Co-authored-by: Saransh Chopra <saransh0701@gmail.com>
* Support Python 3.9+ * drop 3.8 in CI --------- Co-authored-by: Robert Timms <robertwtimms@gmail.com> Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
* feat: migrate to pydantic v2 * fix: typo in project urls * fix: type hints compat python >= 3.8 * fix: clean function tempfile * fix: clean function cache * Fix pyproject * Fix type errors * Revert some changes * Reorganize code * Put some files back * Minor cleanup * Fix type annotation --------- Co-authored-by: Chuck Liu <liuchengkun@finalfrontier.cn> Co-authored-by: Robert Timms <43040151+rtimms@users.noreply.github.com>
* Remove dependency, update version * A few small fixes * Fix string parsing issue * Remove problematic delete * Another small fix * Cleanup * Experiment * Revert experiment * Test cleanup * Experiment * Attempt to get the new values * Revert change * Fix tests * Update test workflow
Updating the changelog to match FaradayInstitution#81
* Add dependabot for automatic workflow updates * Fix typo
* ci: fix coverage + minor touch ups * install hatch * run CI on main * oops, fix syntax * add conda * 3.13 in too * a bit more cleanup
Bumps the actions group with 4 updates: [actions/checkout](https://github.com/actions/checkout), [actions/setup-python](https://github.com/actions/setup-python), [actions/upload-artifact](https://github.com/actions/upload-artifact) and [codecov/codecov-action](https://github.com/codecov/codecov-action). Updates `actions/checkout` from 3 to 4 - [Release notes](https://github.com/actions/checkout/releases) - [Commits](actions/checkout@v3...v4) Updates `actions/setup-python` from 4 to 5 - [Release notes](https://github.com/actions/setup-python/releases) - [Commits](actions/setup-python@v4...v5) Updates `actions/upload-artifact` from 4.4.3 to 4.5.0 - [Release notes](https://github.com/actions/upload-artifact/releases) - [Commits](actions/upload-artifact@b4b15b8...6f51ac0) Updates `codecov/codecov-action` from 2 to 5 - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v2...v5) --- updated-dependencies: - dependency-name: actions/checkout dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/setup-python dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions - dependency-name: actions/upload-artifact dependency-type: direct:production update-type: version-update:semver-minor dependency-group: actions - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-major dependency-group: actions ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…unctions-functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
I would like to be able to specify custom function in my codebase (which returns a pybamm compatible function) in a BPX json file by passing the called function name and any arguments.
Example:
"OCP [V]": "mypackage.mymodule.myfunction('arg1','arg2')"In this case, an import should be added to the preamble, for the package name, and then the function should not be treated as a mathmatical expression.
TODO: