Remove synchronization from CsvMapper
#468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowtowncoder
approved these changes
Mar 28, 2024
cowtowncoder
changed the title
CsvMapper
cowtowncoder
added a commit
that referenced
this pull request
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRUMap can handle concurrent gets and puts.
The existing code does not stop 2 threads from getting null from the initial get and both creating new schemas and putting them to the LRUMap with the same key. We would need a more complicated solution to ensure that schemas were only created once. I don't think that we need that - the code is a good effort at avoiding creating schema instances over and over while avoiding the locking required to make it happen once and once only.