Skip to content

Commit

Permalink
[JSTEP-10] Remove /failing tests exclusion (#353)
Browse files Browse the repository at this point in the history
  • Loading branch information
JooHyukKim authored Jan 29, 2025
1 parent cfa78ec commit 6d27674
Show file tree
Hide file tree
Showing 8 changed files with 17 additions and 20 deletions.
5 changes: 0 additions & 5 deletions datatypes/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,6 @@ JDK 8 data types.
<groupId>org.apache.maven.plugins</groupId>
<version>${version.plugin.surefire}</version>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
<exclude>com/fasterxml/jackson/failing/*.java</exclude>
</excludes>
</configuration>
</plugin>
<plugin>
<!-- Inherited from oss-base. Generate PackageVersion.java.-->
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.datatype.jsr310.failing;
package com.fasterxml.jackson.datatype.jsr310.tofix;

import java.time.Duration;

Expand All @@ -7,11 +7,13 @@
import com.fasterxml.jackson.databind.*;

import com.fasterxml.jackson.datatype.jsr310.ModuleTestBase;
import com.fasterxml.jackson.datatype.jsr310.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.assertEquals;

public class DurationDeser337Test extends ModuleTestBase
{
@JacksonTestFailureExpected
@Test
public void test_default() throws Exception {
ObjectMapper mapper = newMapper();
Expand All @@ -29,6 +31,7 @@ public void test_default() throws Exception {
}

// Handling with WRITE_DURATIONS_AS_TIMESTAMPS enabled can't round-trip a value
@JacksonTestFailureExpected
@Test
public void test_with() throws Exception {
ObjectMapper mapper = mapperBuilder()
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.datatype.jsr310.failing;
package com.fasterxml.jackson.datatype.jsr310.tofix;

import java.time.Instant;

Expand All @@ -7,6 +7,7 @@
import com.fasterxml.jackson.databind.JsonNode;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.datatype.jsr310.ModuleTestBase;
import com.fasterxml.jackson.datatype.jsr310.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -32,6 +33,7 @@ public void instantViaReadValue() throws Exception {
assertEquals(ISSUED_AT, deserialized.value);
}

@JacksonTestFailureExpected
@Test
public void instantViaReadTree() throws Exception {
String serialized = MAPPER.writeValueAsString(new Wrapper307(ISSUED_AT));
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.datatype.jsr310.failing;
package com.fasterxml.jackson.datatype.jsr310.tofix;

import java.io.*;
import java.time.Year;
Expand All @@ -8,11 +8,13 @@
import com.fasterxml.jackson.datatype.jsr310.*;

import com.fasterxml.jackson.databind.*;
import com.fasterxml.jackson.datatype.jsr310.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

public class JDKSerializabilityTest extends ModuleTestBase
{
@JacksonTestFailureExpected
@Test
public void testJDKSerializability() throws Exception {
final Year input = Year.of(1986);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.datatype.jsr310.failing;
package com.fasterxml.jackson.datatype.jsr310.tofix;

import java.time.OffsetDateTime;
import java.time.ZoneId;
Expand All @@ -9,6 +9,7 @@
import com.fasterxml.jackson.annotation.JsonFormat;
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.datatype.jsr310.ModuleTestBase;
import com.fasterxml.jackson.datatype.jsr310.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -33,6 +34,7 @@ public void setDate(OffsetDateTime date) {
private ObjectMapper MAPPER = newMapper();

// For [modules-java8#279]
@JacksonTestFailureExpected
@Test
public void testWrapperWithPattern279() throws Exception
{
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package com.fasterxml.jackson.datatype.jsr310.failing;
package com.fasterxml.jackson.datatype.jsr310.tofix;

import java.time.ZoneId;
import java.time.ZoneOffset;
Expand All @@ -9,6 +9,7 @@
import com.fasterxml.jackson.databind.ObjectMapper;
import com.fasterxml.jackson.databind.SerializationFeature;
import com.fasterxml.jackson.datatype.jsr310.ModuleTestBase;
import com.fasterxml.jackson.datatype.jsr310.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.*;

Expand All @@ -21,6 +22,7 @@ public class ZonedDateTimeIssue244Test extends ModuleTestBase
.disable(SerializationFeature.WRITE_DATES_AS_TIMESTAMPS)
.build();

@JacksonTestFailureExpected
@Test
public void zoneIdUTC() throws Exception
{
Expand All @@ -33,6 +35,7 @@ public void zoneOffsetUTC() throws Exception
assertSerializeAndDeserialize(ZonedDateTime.now(ZoneOffset.UTC)); // fails!
}

@JacksonTestFailureExpected
@Test
public void zoneOffsetNonUTC() throws Exception
{
Expand Down
5 changes: 0 additions & 5 deletions parameter-names/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -96,11 +96,6 @@ introspection of method/constructor parameter names, without having to add expli
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<version>${version.plugin.surefire}</version>
<configuration>
<excludes>
<exclude>${packageVersion.dir}/failing/*.java</exclude>
</excludes>
</configuration>
</plugin>
<!-- 28-Mar-2019, tatu: Add rudimentary JDK9+ module info. To build with JDK 8
will have to use `moduleInfoFile` as anything else requires JDK 9+
Expand Down
5 changes: 0 additions & 5 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,6 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-surefire-plugin</artifactId>
<configuration>
<excludes>
<exclude>com/fasterxml/jackson/**/failing/*.java</exclude>
</excludes>
</configuration>
</plugin>
</plugins>
</pluginManagement>
Expand Down

0 comments on commit 6d27674

Please sign in to comment.