Add status timeout feature#311
Open
DerEchteDimenzio wants to merge 1 commit intoFchat-Horizon:developmentfrom
Open
Add status timeout feature#311DerEchteDimenzio wants to merge 1 commit intoFchat-Horizon:developmentfrom
DerEchteDimenzio wants to merge 1 commit intoFchat-Horizon:developmentfrom
Conversation
Contributor
|
How does this interact with the idle timer? Does setting a status for X minutes reset your idle status if the timer for the latter is X-1 minutes? I'll look a bit into the actual implementation later though, doubly so since you wanted some feedback on that. |
Contributor
|
Hi @DerEchteDimenzio. Are you still working on this and #312? Did you have time to go over the feedback yet? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #229
Feedback appreciated, especially regarding interface and file structure.