Adds CSS plugins to Horizon.#422
Open
king5327 wants to merge 1 commit intoFchat-Horizon:developmentfrom
Open
Conversation
Added a setting that allows Horizon to selectively load custom CSS from files in horizon-config/Plugins at user request.
Member
|
Will review this tomorrow. |
Contributor
|
Best to wait until 1.34 is done and out before we merge this, so we can actually test and look at it properly. |
Contributor
|
I do want this added still, but now that we have the time to look into it again, I'm still of the opinion that for applying the CSS styles themselves, it's probably better (and safer) to do so through Electron's APIs for that. Similar to how the current custom CSS option would allow you to. Do you think you can integrate the backend of this feature with that same system? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a setting that allows Horizon to selectively load custom CSS from files in horizon-config/Plugins at user request.