Shorten wikilink block completion paths - #436
Open
devin-ai-integration[bot] wants to merge 1 commit into
Open
Conversation
Co-Authored-By: Felix Zeller <felixazeller@gmail.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #421 by changing wikilink block completions to prefer filename-only block references when safe.
shorten_block_ref_pathshook to distinguish wikilink completions from markdown link completions.Filename#^blockid|displayinstead offolder/path/Filename#^blockid|displayunless the short reference would be ambiguous.Review & Testing Checklist for Human
[[ <query>block completion: unique filenames should insertFilename#^id|text, while duplicate filenames should still use the full path.Notes
Local validation run:
cargo fmt --checkcargo clippy(passed with existing unrelated warnings)cargo test(passed with existing unrelated warning)Link to Devin session: https://app.devin.ai/sessions/ed2e0a94bfdb4138995a0b7228ef4095
Requested by: @Feel-ix-343