Output an icon size only #1739
Open
Output an icon size only #1739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need to be tested & fixed, or removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
I think that outputting multiple sizes is unnecessary and it brings more processing time (CPU times, I see a big time at Firefox Nightly's
IconDetails.normalize).High resolution display is untested.
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/browserAction/setIcon
https://developer.chrome.com/extensions/browserAction
Compatibility
Is this PR compatible with old versions? Can users simply upgrade the extension?
Yes.
Please describe any possible breaking changes (or surprising UX differences).
Should not. Firefox Nightly tested.
Screenshots (if applicable)
N/A.