Expose allowForDecryption through ITaskManager and FHE - #105
Open
Dusk1e wants to merge 1 commit into
Open
Conversation
TaskManager.allowForDecryption is external with no access control and is in the ABI of both task managers, but ITaskManager never declared it, so library FHE had no wrapper for it. FHE.sol already exposes the read half of that flow through getDecryptResult. Added the declaration and wrappers for all seven encrypted types, following the allowGlobal and allowTransient blocks, plus the matching bindings entries. Nothing under detereministic-tm changes.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskManager.allowForDecryption is external with no access control and is in the ABI of both task managers, but ITaskManager never declares it, so library FHE cannot wrap it. FHE.sol already exposes the read half of that flow through getDecryptResult, and the SDK's MockTaskManager logs the call as FHE.allowForDecryption, so the library is expected to carry the name.
Added the declaration and wrappers for all seven encrypted types, following the allowGlobal and allowTransient blocks, plus the matching bindings entries. Nothing under detereministic-tm changes, so DeterministicTM keeps compiling against its own interface copy.
Tests: 65 of 65 pass, same as master. compile, storage-layout:check, check:size and solhint are clean. One thing worth flagging: ACL gains 69 bytes with no ABI change, which is viaIR whole-unit compilation shifting Yul function offsets. Compiled on its own, ACL is byte identical before and after, and TaskManager stays at 17863 bytes.