Declare the upgrades-core dependency the storage-layout task imports - #113
Open
Dusk1e wants to merge 1 commit into
Open
Declare the upgrades-core dependency the storage-layout task imports#113Dusk1e wants to merge 1 commit into
Dusk1e wants to merge 1 commit into
Conversation
tasks/storageLayout.ts calls validate, solcInputOutputDecoder, concatRunData, getContractVersion, getStorageLayout, getStorageUpgradeReport and withValidationDefaults from @openzeppelin/upgrades-core, but the package was never declared. It resolved only because pnpm hoists it as a transitive dependency of @openzeppelin/hardhat-upgrades. Pinned to the same range hardhat-upgrades asks for, so the resolved version is unchanged at 1.44.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tasks/storageLayout.tsimports seven runtime functions from@openzeppelin/upgrades-core—validate,solcInputOutputDecoder,concatRunData,getContractVersion,getStorageLayout,getStorageUpgradeReportandwithValidationDefaults— but the package is not in the host-chain manifest. It resolves today only because pnpm hoists it into.pnpm/node_modulesas a transitive dependency of@openzeppelin/hardhat-upgrades.That makes the storage-layout job dependent on hoisting behavior and on a package it does not ask for.
tsc --noEmitalready reports it asTS2307: Cannot find module '@openzeppelin/upgrades-core', which is the same shape as thegetProxyContractarity bug in the last release, where ts-node transpiled past a type error thattscwould have caught.Declared it at
^1.41.0, the range@openzeppelin/hardhat-upgradesitself asks for, so the resolved version stays 1.44.2 and the lockfile gains three lines.Tests: 116 of 116 pass. compile, storage-layout:check, check:size and solhint are unchanged. The
TS2307is gone and no other tsc diagnostic moved, 95 to 94.