fix(deploy): actually land ACPShareRegistry on ACP setup - #117
Open
crazywriter1 wants to merge 1 commit into
Open
fix(deploy): actually land ACPShareRegistry on ACP setup#117crazywriter1 wants to merge 1 commit into
crazywriter1 wants to merge 1 commit into
Conversation
FhenixProtocol#111 fixed argument order but initialize arity still mismatched, errors were swallowed, and ACL setters signed as wallets.json[0] instead of the real admin.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initializeforACPShareRegistry(getProxyContractwas still encoding(admin, delay)againstinitialize(address))return e(deploy stayed green withsetShareRegistrynever called)adminSigner, notwallets.json[0]/aggregatorSigners[0]#111 fixed argument order only; arity mismatch + swallowed errors left
ACL.shareRegistry == 0, so everywithACP()decrypt failed atsealOutput.Test plan
ACL.shareRegistryis non-zeroinitializefor ACPShareRegistry throws (types/values length mismatch) so the failure is not silent