fix(react): add missing FloatingButtonPage import in SendPage.tsx - #303
Open
ygd58 wants to merge 2 commits into
Open
fix(react): add missing FloatingButtonPage import in SendPage.tsx#303ygd58 wants to merge 2 commits into
ygd58 wants to merge 2 commits into
Conversation
SendPage.tsx referenced FloatingButtonPage.Send inside its ambient module augmentation block without importing FloatingButtonPage, unlike the identical pattern in PortfolioPage.tsx. TypeScript's type-only ambient declaration doesn't flag this, but ESLint's no-undef rule correctly catches it as an undefined identifier.
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
@ygd58 is attempting to deploy a commit to the Fhenix Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SendPage.tsxusesFloatingButtonPage.Sendinside itsdeclare moduleblock forFloatingButtonPagePropsRegistryaugmentation, but never importsFloatingButtonPage— unlike the identical pattern inPortfolioPage.tsx, which imports it correctly. This passestsc(type-only ambient context) but fails ESLintno-undef. Fixed by adding the missing import.Verified locally:
pnpm lint— warning resolvedpnpm check:types— cleanpnpm check:formatting— clean