fix(node): make filesystem storage writes atomic - #330
Open
pekkahcut wants to merge 2 commits into
Open
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
🦋 Changeset detectedLatest commit: 5e5fb62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@pekkahcut is attempting to deploy a commit to the Fhenix Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The Node storage implementation wrote directly to the final
.cofhesdk/<name>.jsonfile.If the process was interrupted while that write was in progress, the existing persisted storage could be left partially written or invalid. A subsequent read would then fail to parse the JSON and fall back to in-memory storage.
Writing to a temporary file first and renaming it into place avoids exposing a partially written destination file.
Tests
pnpm --filter @cofhe/sdk test -- node/test/storage.test.ts— passesgit diff --check— passesThe full SDK test run is currently blocked locally by the existing
@cofhe/test-setuppackage-entry resolution issue, unrelated to these changes.